Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump tonic to v0.12 #17889

Merged
merged 34 commits into from
Aug 14, 2024
Merged

chore: bump tonic to v0.12 #17889

merged 34 commits into from
Aug 14, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Aug 1, 2024 •
edited
Loading

Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

See #13695.

This PR bumps tonic to v0.12, prost to 0.13, http and hyper to v1 in relevant modules. There are still indirect dependencies on tonic v0.10 and v0.11 due to external dependencies, as described in the issue. Mark them with TODO(http-bump) and leave them to future work.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao requested a review from a team as a code owner August 1, 2024 07:04
@BugenZhao BugenZhao requested a review from xxchan August 1, 2024 07:04
@BugenZhao BugenZhao marked this pull request as draft August 1, 2024 07:04
@BugenZhao BugenZhao changed the title chore: try try tonic 0.12 chore: bump tonic to 0.12 Aug 2, 2024
@BugenZhao BugenZhao changed the title chore: bump tonic to 0.12 chore: bump tonic to v0.12 Aug 2, 2024
@BugenZhao BugenZhao marked this pull request as ready for review August 2, 2024 03:44
@BugenZhao BugenZhao requested a review from fuyufjh August 2, 2024 03:45
fuyufjh
fuyufjh approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems no logic changes. LGTM as long as the tests can pass

@graphite-app graphite-app bot requested a review from a team August 2, 2024 09:25
BugenZhao added 18 commits August 2, 2024 17:42
@BugenZhao
try try tonic 0.12
ef2deb2 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
bump more
9988967 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
manually downgrade array
5fc57af 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
bump more more
34062d7 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
downgrade arrow again, generate patch
dba2100 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
cleanups
aa20289 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
bump console-api
9830565 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
bump google cloud pubsub & downgrade tonic in ginepro
975e8e2 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
add oltp embedded back
1c5d456 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
fix monitor connection impl
8e89f84 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
fix compatibility of monitor connection
7f6f955 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
remove
8504598 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
use crates.io madsim
4267c37 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
patch tokio-stream
5e6ae4a 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
fix clippy
d0446b2 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
fix more clippy
ad83a3f 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
do not patch tokio-stream
44249b8 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
try try fix madsim
0e033b9 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
fix check
263d38c 
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao
Copy link
Member Author

Currently blocked due to a panic in simulation test. See #17920.

@wenym1
Copy link
Contributor

wenym1 commented Aug 8, 2024

The previous panic should have been fixed in #17955

@BugenZhao BugenZhao mentioned this pull request Aug 12, 2024
Closed
@BugenZhao
Copy link
Member Author

BugenZhao commented Aug 14, 2024 •
edited
Loading

e2e-sink-test now consistently hangs here:

risingwave/e2e_test/sink/kafka/avro.slt

Lines 189 to 196 in 8d8c136

statement error test-rw-sink-upsert-avro-err-key
create sink sink_err from into_kafka with (
connector = 'kafka',
topic = 'test-rw-sink-upsert-avro-err',
properties.bootstrap.server = 'message_queue:29092',
primary_key = 'int32_field,string_field')
format upsert encode avro (
schema.registry = 'http://schemaregistry:8082');

I find that by disabling SCHEMA_REGISTRY_DEBUG here, this issue is gone.

risingwave/ci/docker-compose.yml

Line 269 in 8d8c136

SCHEMA_REGISTRY_DEBUG: 'true'

The only difference is that there won't be backtraces from the schema registry in the error message.

failed to validate sink: config error: all request confluent registry all timeout, req path ["subjects", "test-rw-sink-upsert-avro-err-key", "versions", "latest"], urls http://schemaregistry:8082/
	confluent schema registry error 40401: Subject 'test-rw-sink-upsert-avro-err-key' not found. io.confluent.rest.exceptions.RestNotFoundException: Subject 'test-rw-sink-upsert-avro-err-key' not found.
- io.confluent.rest.exceptions.RestNotFoundException: Subject 'test-rw-sink-upsert-avro-err-key' not found.
-	at io.confluent.kafka.schemaregistry.rest.exceptions.Errors.subjectNotFoundException(Errors.java:78)
-	at io.confluent.kafka.schemaregistry.rest.resources.SubjectVersionsResource.getSchemaByVersion(SubjectVersionsResource.java:154)
-	at jdk.internal.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)

Following this insight, I suppose it's because we always encode the ServerError in gRPC (HTTP2) headers (#13282), and there's an outstanding issue where tonic 0.12 will hang forever when the header size exceeds some limit.

risingwave/src/error/src/tonic.rs

Lines 68 to 71 in 8d8c136

let serialized = bincode::serialize(&source).unwrap();
let mut metadata = MetadataMap::new();
metadata.insert_bin(ERROR_KEY, MetadataValue::from_bytes(&serialized));

Upstream issues:

ATM there seems to be no fix. I'll disable SCHEMA_REGISTRY_DEBUG now as a workaround and open an issue for this.

@graphite-app graphite-app bot requested a review from a team August 14, 2024 06:37
@BugenZhao BugenZhao added this pull request to the merge queue Aug 14, 2024
@BugenZhao BugenZhao mentioned this pull request Aug 14, 2024
Closed
Merged via the queue into main with commit e96c39d Aug 14, 2024
30 of 31 checks passed
@BugenZhao BugenZhao deleted the bz/tonic-0-12 branch August 14, 2024 07:37
StrikeW added a commit that referenced this pull request Aug 14, 2024
@StrikeW
Revert "chore: bump tonic to v0.12 (#17889)"
756d840 
This reverts commit e96c39d.
StrikeW added a commit that referenced this pull request Aug 14, 2024
@StrikeW
Reapply "chore: bump tonic to v0.12 (#17889)"
ddd667a 
This reverts commit 756d840.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

@xxchan xxchan Awaiting requested review from xxchan xxchan is a code owner automatically assigned from risingwavelabs/cargo-lock

Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests type/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BugenZhao @wenym1 @fuyufjh