Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F38 enable ostree containers #4617

Merged

Conversation

jkonecny12
Copy link
Member

Backport of #4561

RPM OSTree is getting new functionality to use containers as the base
image. Thanks to that it's possible to use standard container
repositories.

This source enables to use these repositories.

Related: rhbz#2125655
We have a new RPMOStreeContainer source now which enables us to use
containers as installation source. In this commit we adapt the current
rpm_ostree to be able to consume this new container source.

Add a lot of rpm ostree tasks tests for the container source.

Resolves: rhbz#2125655
@jkonecny12 jkonecny12 added release note required Write a release note for this change. f38 Fedora 38 labels Mar 16, 2023
There is already existing top level function to create the same, so
let's re-use it and remove duplication.
Our intention is to move dependencies specific for Anaconda execution
from Lorax into Anaconda. Let's do that for rpm-ostree because we need
to also add `skopeo` project to be able to download container images.

Require rpm-ostree version which contains:
- ostreedev/ostree-rs-ext#464 (simplified
syntax)
- ostreedev/ostree-rs-ext#462 (stateroot is not
mandatory)

Related: rhbz#2125655
Based on my discussion and recommendation on the bug, the 'registry'
transport should be the only one which needs network to work. Other ways
of transport should be used for local management.

Related: rhbz#2125655
@jkonecny12 jkonecny12 force-pushed the f38-enable-ostree-containers branch from 6860ba1 to 3bbeaad Compare March 16, 2023 16:03
@jkonecny12
Copy link
Member Author

Fixed typo in release notes and remove unused method.

@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

@jkonecny12
Copy link
Member Author

jkonecny12 commented Mar 17, 2023

The unit test issue is not related to this PR:

where False = isinstance(<parse_kickstart_for_dracut_test.DracutNetwork object at 0x7fcfd9c3cc50>, <class 'pykickstart.commands.network.F38_Network'>)

Solved by removing it from F38 handler pykickstart/pykickstart#448

@jkonecny12
Copy link
Member Author

Cockpit tests needs a new image with newer pykickstart 3.46. Similar to #4561 (comment)

Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@jkonecny12 jkonecny12 merged commit 6e0ac8f into rhinstaller:fedora-38 Mar 21, 2023
@jkonecny12 jkonecny12 removed the release note required Write a release note for this change. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f38 Fedora 38
Development

Successfully merging this pull request may close these issues.

3 participants