Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guess the default product name from the os-release files #3155

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Guess the default product name from the os-release files #3155

merged 1 commit into from
Feb 11, 2021

Conversation

poncovka
Copy link
Contributor

Don't use the hard-coded default product. Use the product name from
the os-release files of the installation environment. See the commit
849a018.

@poncovka
Guess the default product name from the os-release files
519281c 
Don't use the hard-coded default product. Use the product name from
the os-release files of the installation environment. See the commit
849a018.
@poncovka poncovka added master Please, use the `f39` label instead. manual testing required This issue can't be merged without manual testing and removed manual testing required This issue can't be merged without manual testing labels Feb 10, 2021
@poncovka poncovka marked this pull request as ready for review February 10, 2021 14:57
@poncovka
Copy link
Contributor Author

/kickstart-test --testtype smoke

rvykydal
rvykydal approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

VladimirSlavik
VladimirSlavik approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's clever! Thanks!

@poncovka poncovka merged commit 0c92ef3 into rhinstaller:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

@rvykydal rvykydal rvykydal approved these changes

Assignees
No one assigned
Labels
master Please, use the `f39` label instead.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poncovka @rvykydal @VladimirSlavik