Warn on invalid host name in kickstart (#1897514) #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/packit build |
|
/kickstart-test --testtype smoke |
|
Please, write a unit test for this use case. |
37a58c3 to
b067306
Compare
|
Waiting for pykickstart PR. If unblocked and to be continued, tests are still TODO. |
|
Not doing pykickstart, so not blocked. |
b067306 to
356a1e2
Compare
|
/kickstart-test --testtype smoke |
|
Update: Logic is now in |
poncovka
suggested changes
Feb 5, 2021
tests/nosetests/pyanaconda_tests/modules/network/module_network_kickstart_test.py
Outdated
Show resolved
Hide resolved
Do that instead of crashing with no message. Resolves: rhbz#1897514
356a1e2 to
4fd7b99
Compare
|
Thank you, done. |
poncovka
approved these changes
Feb 8, 2021
|
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do that instead of crashing.
Resolves: rhbz#1897514
I have no idea where to put that warning? Or maybe I could use the stock pykickstart one. Opinions welcome.Pinging @jstodola because it changes behavior, from crashing to... something.