Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatibility with PHPUnit 7 and fix false negative test results, use legacy PHPUnit 5 on legacy HHVM, skip signal tests when PCNTL is not available and skip timer tests on inacurrate platforms #181

Merged
merged 2 commits into from
Feb 4, 2019

Conversation

clue
Copy link
Member

@clue clue commented Feb 4, 2019

Builds on top of #120 and clue/socket-raw#42

clue added 2 commits February 4, 2019 12:12
The signal constants are only available when ext-pcntl is loaded. If it
is not loaded, simply skip all tests that reference these constants.

Before running a timer test and asserting its time interval, run a
simple test to check the accuracy on the current platform. This is known
to work on most common platforms, but will now avoid false negative test
results on platforms that are known to be slow (Travis CI and others).
@clue clue added this to the v1.1.0 milestone Feb 4, 2019
@WyriHaximus WyriHaximus requested a review from jsor February 4, 2019 13:14
@jsor jsor merged commit 7016d65 into reactphp:master Feb 4, 2019
@clue clue deleted the tests branch February 4, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants