🌈 Fixes a bug in the calculation of the print_wrapped method #719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a bug that caused the
print_wrapped
method in theThor::Shell::Basic
class to incorrectly wrap the text when printing on the terminal. The reason for the bug is that the method assumes that the loop starts with the first word, when in fact it starts with the second word and the first word is already in thememo
variable.Before the change:
After the change
To see why this occurs you can run the following code on IRB or PRY:
As you can see the first iteration already has
"hello"
inmemo
and the firstword
is actually"word!"
. Theprint_wrapped
was not accounting for this and therefore given the right conditions the method would print beyond the edge of the terminal.