Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting to Python code examples in README.rst [docs] #1208

Merged
merged 7 commits into from
Aug 23, 2020
Merged

Add syntax highlighting to Python code examples in README.rst [docs] #1208

merged 7 commits into from
Aug 23, 2020

Conversation

SFM61319
Copy link
Contributor

What does this implement/fix? Explain your changes.

Added the syntax highlighting to the Python code examples in README.rst documentation

Does this close any currently open issues?

Yes, this solves issue #1207

Any other comments?

No.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@dnfadmin
Copy link

dnfadmin commented Aug 21, 2020

CLA assistant check
All CLA requirements met.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #1208 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1208   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files           1        1           
  Lines         291      291           
=======================================
  Hits          251      251           
  Misses         40       40           
Flag Coverage Δ
#setup_linux 64.94% <ø> (ø)
#setup_windows 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b989cb...7fbc531. Read the comment docs.

@lostmsu
Copy link
Member

lostmsu commented Aug 22, 2020

No need for CHANGELOG entry for README.

@SFM61319
Copy link
Contributor Author

SFM61319 commented Aug 22, 2020

@lostmsu so should I remove the line from CHANGELOG.md and create a PR again? Or I was thinking of getting this merged into the master branch and then, since I will have write powers, I can just remove that line and close that issue #1207 at the same time.

@lostmsu
Copy link
Member

lostmsu commented Aug 22, 2020

@SFM61319 you will not get write powers just for getting a PR accepted. You need to revert the commit updating changelog in your branch. PR will be updated once you push this change.

@filmor filmor merged commit 29978d8 into pythonnet:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants