Parameters marked with ParameterAttributes.Out are no longer return…

…ed in addition to the regular method return value (unless they are passed with `ref` or `out` keyword).
pythonnet · Dec 8, 2020 · b7e2699 · b7e2699
1 parent 57f4a80
commit b7e2699
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,8 @@ details about the cause of the failure
      able to access members that are part of the implementation class, but not the
      interface.  Use the new __implementation__ or __raw_implementation__ properties to
      if you need to "downcast" to the implementation class.
+-   Parameters marked with `ParameterAttributes.Out` are no longer returned in addition
+     to the regular method return value (unless they are passed with `ref` or `out` keyword).
 
 ### Fixed
 

diff --git a/src/runtime/methodbinder.cs b/src/runtime/methodbinder.cs
@@ -534,7 +534,7 @@ static object[] TryConvertArguments(ParameterInfo[] pi, bool paramsArray,
                     Runtime.XDecref(op);
                 }
 
-                if (parameter.IsOut || isOut)
+                if (isOut)
                 {
                     outs++;
                 }

diff --git a/src/tests/test_method.py b/src/tests/test_method.py
@@ -761,7 +761,7 @@ def test_we_can_bind_to_encoding_get_string():
     read = 1
 
     while read > 0:
-        read, _ = stream.Read(buff, 0, buff.Length)
+        read = stream.Read(buff, 0, buff.Length)
         temp = Encoding.UTF8.GetString(buff, 0, read)
         data.append(temp)
-Original file line number
+Diff line change
@@ Expand Up @@
                         Runtime.XDecref(op);
                     }
-                    if (parameter.IsOut || isOut)
+                    if (isOut)
                     {
                         outs++;
                     }
@@ Expand Down @@