Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module #99373

Merged
python:main from
Nov 14, 2022
Merged

gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module #99373

python:main from
Nov 14, 2022

Conversation

zooba
Copy link
Member

@zooba Nov 11, 2022 •
edited by bedevere-bot
Loading

type-security A security issue needs backport to 3.8 needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 11, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 11, 2022
Closed
gpshead
gpshead approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably of marginal value, but harrmless, it nudges the bar slightly higher. nice discussion on the issue.

4e4b13e into python:main Nov 14, 2022
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-99491 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 14, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 14, 2022
@miss-islington
pythongh-87604: Avoid publishing list of active per-interpreter audit…
e60ced7 
… hooks via the gc module (pythonGH-99373)

(cherry picked from commit 4e4b13e)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot
Copy link

GH-99492 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 14, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 14, 2022
@miss-islington
pythongh-87604: Avoid publishing list of active per-interpreter audit…
d73af8e 
… hooks via the gc module (pythonGH-99373)

(cherry picked from commit 4e4b13e)

Co-authored-by: Steve Dower <[email protected]>
@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4e4b13e8f6211abbc0d53056da11357756daa314 3.9

@miss-islington
Copy link
Contributor

Sorry @zooba, I had trouble checking out the 3.8 backport branch.
Please retry by removing and re-adding the "needs backport to 3.8" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 4e4b13e8f6211abbc0d53056da11357756daa314 3.8

@bedevere-bot
Copy link

GH-99493 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 14, 2022
miss-islington added a commit that referenced this pull request Nov 15, 2022
@miss-islington
gh-87604: Avoid publishing list of active per-interpreter audit hooks…
e470803 
… via the gc module (GH-99373)

(cherry picked from commit 4e4b13e)

Co-authored-by: Steve Dower <[email protected]>
miss-islington added a commit that referenced this pull request Nov 15, 2022
@miss-islington
gh-87604: Avoid publishing list of active per-interpreter audit hooks…
f4cb828 
… via the gc module (GH-99373)

(cherry picked from commit 4e4b13e)

Co-authored-by: Steve Dower <[email protected]>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Nov 16, 2022
@CuriousLearner
Merge branch 'main' into fix-issue21914
abd206e 
* main: (8272 commits)
  Update Windows readme.txt to clarify Visual Studio required versions (pythonGH-99522)
  pythongh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (python#99461)
  pythongh-92647: [Enum] use final status to determine lookup or create (pythonGH-99500)
  pythongh-81057: Move Globals in Core Code to _PyRuntimeState (pythongh-99496)
  Post 3.12.0a2
  pythongh-99300: Use Py_NewRef() in Python/Python-ast.c (python#99499)
  pythongh-93649: Split pytime and datetime tests from _testcapimodule.c (python#99494)
  pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-99483)
  pythonGH-99205: remove `_static` field from `PyThreadState` and `PyInterpreterState` (pythonGH-99385)
  pythongh-81057: Move the Remaining Import State Globals to _PyRuntimeState (pythongh-99488)
  pythongh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (pythonGH-99373)
  pythongh-93649: Split getargs tests from _testcapimodule.c (python#99346)
  pythongh-81057: Move Global Variables Holding Objects to _PyRuntimeState. (pythongh-99487)
  pythonGH-98219: reduce sleep time in `asyncio` subprocess test (python#99464)
  pythonGH-99388: add `loop_factory` parameter to `asyncio.run` (python#99462)
  pythongh-99300: Use Py_NewRef() in PC/ directory (python#99479)
  pythongh-99300: Use Py_NewRef() in Doc/ directory  (python#99480)
  pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99473)
  pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99469)
  pythongh-99370: Calculate zip path from prefix when in a venv (pythonGH-99371)
  ...
ambv pushed a commit that referenced this pull request Nov 21, 2022
[3.9] gh-87604: Avoid publishing list of active per-interpreter audit…
7b98207 
… hooks via the gc module (GH-99373) (GH-99493)
@bedevere-bot
Copy link

GH-99661 is a backport of this pull request to the 3.8 branch.

ambv pushed a commit that referenced this pull request Nov 21, 2022
@miss-islington
[3.8] gh-87604: Avoid publishing list of active per-interpreter audit…
b50b6f9 
… hooks via the gc module (GH-99373) (GH-99661)

(cherry picked from commit 7b98207)

Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

zooba

Labels
type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @bedevere-bot @gpshead