Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-85984: Remove legacy Lib/pty.py code. #92365

Merged
merged 7 commits into from
Feb 9, 2023
Merged

gh-85984: Remove legacy Lib/pty.py code. #92365

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
287d09a
Use os.login_tty() in pty.fork() on systems that lack os.forkpty().
8vasu Feb 5, 2023
89faf29
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 5, 2023
1473bf5
Add DeprecationWarning to master_open and slave_open
gpshead Feb 6, 2023
662d81d
mention the deprecation warnings in NEWS
gpshead Feb 6, 2023
820bc05
Add a whatsnew entry regarding the 3.14 removals.
gpshead Feb 6, 2023
b0bead8
fix whitespace
gpshead Feb 6, 2023
4287962
updated news wording
gpshead Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add DeprecationWarning to master_open and slave_open
  • Loading branch information
@gpshead
gpshead authored Feb 6, 2023
commit 1473bf56e25ac759c3d6753442e014935ebe38a8
6 changes: 6 additions & 0 deletions Lib/pty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ def master_open():
"""master_open() -> (master_fd, slave_name)
Open a pty master and return the fd, and the filename of the slave end.
Deprecated, use openpty() instead."""

import warnings
warnings.warn("Use pty.openpty() instead.", DeprecationWarning, stacklevel=2) # Remove API in 3.14

try:
master_fd, slave_fd = os.openpty()
Expand Down Expand Up @@ -69,6 +72,9 @@ def slave_open(tty_name):
opened filedescriptor.
Deprecated, use openpty() instead."""

import warnings
warnings.warn("Use pty.openpty() instead.", DeprecationWarning, stacklevel=2) # Remove API in 3.14

result = os.open(tty_name, os.O_RDWR)
try:
from fcntl import ioctl, I_PUSH
Expand Down