-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-92031: Deoptimize Static Code at Finalization #92039
Conversation
🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit df424cf 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
One remark: this will convert EXTENDED_ARG_QUICK to EXTENDED_ARG for subsequent interpreters using this code, even though EXTENDED_ARG_QUICK is the one emitted by the compiler. We should probably add a case for
The central issue is that |
Feel free to add another table, they are only 256 bytes. |
🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit ad9a38a 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
@markshannon is this okay to merge now? |
Yes it is |
test_repeated_init_exec() already repeats the code 4 times. What is the point of repeating the test 50 x 4 = 200 times? |
The failure was still intermittent when I tried it, and just 4 runs only made the test fail about 10-15% of the time when I measured. |
The Python test suite is run many times per day on each CI job and we have tons of CI jobs. IMO there is no need to loop so many tests inside the test. On buildbots, it's very common that bugs which is barely possible to trigger manually when I really want to reproduce them... fail all the time on a specific worker because each worker has different timings and a different operating system ;-) |
#92031
TODO: