-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-63143: Fix parsing mutually exclusive arguments in argparse #124307
Merged
serhiy-storchaka
merged 2 commits into
python:main
from
serhiy-storchaka:argparse-exclusive-default
Sep 24, 2024
Merged
gh-63143: Fix parsing mutually exclusive arguments in argparse #124307
serhiy-storchaka
merged 2 commits into
python:main
from
serhiy-storchaka:argparse-exclusive-default
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arguments with the value identical to the default value (e.g. booleans, small integers, empty or 1-character strings) are no longer considered "not present".
serhiy-storchaka
added
needs backport to 3.12
bug and security fixes
needs backport to 3.13
bugs and security fixes
labels
Sep 21, 2024
This was referenced Sep 21, 2024
It seems that this issue is very similar to issue #109990 (that issue is to ignore existing optional parameters), but its PR has not been reviewed for a long time. |
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 24, 2024
…ythonGH-124307) Arguments with the value identical to the default value (e.g. booleans, small integers, empty or 1-character strings) are no longer considered "not present". (cherry picked from commit 3094cd1) Co-authored-by: Serhiy Storchaka <[email protected]>
GH-124418 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 24, 2024
…ythonGH-124307) Arguments with the value identical to the default value (e.g. booleans, small integers, empty or 1-character strings) are no longer considered "not present". (cherry picked from commit 3094cd1) Co-authored-by: Serhiy Storchaka <[email protected]>
GH-124419 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 24, 2024
…GH-124307) (GH-124419) Arguments with the value identical to the default value (e.g. booleans, small integers, empty or 1-character strings) are no longer considered "not present". (cherry picked from commit 3094cd1) Co-authored-by: Serhiy Storchaka <[email protected]>
This was referenced Sep 24, 2024
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 7, 2024
…GH-124307) (GH-124418) Arguments with the value identical to the default value (e.g. booleans, small integers, empty or 1-character strings) are no longer considered "not present". (cherry picked from commit 3094cd1) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguments with the value identical to the default value (e.g. booleans, small integers, empty or 1-character strings) are no longer considered "not present".