Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#gh-75705: Set unixfrom envelope in mailbox._mboxMMDF #107117

Merged
merged 5 commits into from
Feb 6, 2024
Merged

#gh-75705: Set unixfrom envelope in mailbox._mboxMMDF #107117

merged 5 commits into from
Feb 6, 2024

Conversation

matthieucan
Copy link
Contributor

@matthieucan matthieucan commented Jul 23, 2023 •
edited by bedevere-bot
Loading

The mailbox._mboxMMDF mailbox format does not set the unixfrom envelope, i.e. the From foo@bar blah header. from and unixfrom are tracked separately in this class.

#75705

@matthieucan matthieucan requested a review from a team as a code owner July 23, 2023 10:31
@bedevere-bot bedevere-bot mentioned this pull request Jul 23, 2023
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly polished the PR.

LGTM.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Feb 1, 2024
@serhiy-storchaka serhiy-storchaka merged commit 76108b8 into python:main Feb 6, 2024
35 checks passed
@miss-islington-app
Copy link

Thanks @matthieucan for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2024
@matthieucan @miss-islington
GH-pythongh-75705: Set unixfrom envelope in mailbox._mboxMMDF (python…
f7b8e25 
…GH-107117)

(cherry picked from commit 76108b8)

Co-authored-by: Matthieu Caneill <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 6, 2024

GH-115098 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2024
@matthieucan @miss-islington
GH-pythongh-75705: Set unixfrom envelope in mailbox._mboxMMDF (python…
bb15d88 
…GH-107117)

(cherry picked from commit 76108b8)

Co-authored-by: Matthieu Caneill <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 6, 2024

GH-115099 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 6, 2024
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.x has failed when building commit 76108b8.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1232/builds/1266) and take a look at the build logs.
  4. Check if the failure is related to this commit (76108b8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1232/builds/1266

Failed tests:

  • test.test_multiprocessing_fork.test_processes

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 11, done.        
remote: Counting objects:  11% (1/9)        
remote: Counting objects:  22% (2/9)        
remote: Counting objects:  33% (3/9)        
remote: Counting objects:  44% (4/9)        
remote: Counting objects:  55% (5/9)        
remote: Counting objects:  66% (6/9)        
remote: Counting objects:  77% (7/9)        
remote: Counting objects:  88% (8/9)        
remote: Counting objects: 100% (9/9)        
remote: Counting objects: 100% (9/9), done.        
remote: Compressing objects:  12% (1/8)        
remote: Compressing objects:  25% (2/8)        
remote: Compressing objects:  37% (3/8)        
remote: Compressing objects:  50% (4/8)        
remote: Compressing objects:  62% (5/8)        
remote: Compressing objects:  75% (6/8)        
remote: Compressing objects:  87% (7/8)        
remote: Compressing objects: 100% (8/8)        
remote: Compressing objects: 100% (8/8), done.        
remote: Total 11 (delta 1), reused 1 (delta 1), pack-reused 2        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '76108b8b05040fc49a6bc50eb2e990576595c57c'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 76108b8b05 #gh-75705: Set unixfrom envelope in mailbox._mboxMMDF (GH-107117)
Switched to and reset branch 'main'

configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

serhiy-storchaka pushed a commit that referenced this pull request Feb 6, 2024
@miss-islington @matthieucan
[3.12] GH-gh-75705: Set unixfrom envelope in mailbox._mboxMMDF (GH-10…
831b95d 
…7117) (GH-115098)

(cherry picked from commit 76108b8)

Co-authored-by: Matthieu Caneill <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Feb 6, 2024
@miss-islington @matthieucan
[3.11] GH-gh-75705: Set unixfrom envelope in mailbox._mboxMMDF (GH-10…
a04dc43 
…7117) (GH-115099)

(cherry picked from commit 76108b8)

Co-authored-by: Matthieu Caneill <[email protected]>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@matthieucan @fsc-eriker
#pythongh-75705: Set unixfrom envelope in mailbox._mboxMMDF (pythonGH…
5484d3b 
…-107117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@bitdancer bitdancer Awaiting requested review from bitdancer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthieucan @bedevere-bot @serhiy-storchaka