Use CSV-separated outputs @ get-changed-files @ CI #105151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because paths with whitespaces tend to crash said action[[1]][[2]][[3]]. Also, we don't need to use JSON as it's harder to parse while the value isn't used except for the emptiness check. The change fixes [[4]] [1]: https://github.com/Ana06/get-changed-files#get-all-changed-files-as-space-delimited [2]: python#103914 (comment) [3]: python#103914 (comment) [4]: python#103914 (comment)
This was referenced May 31, 2023
|
I've made a "demo PR" that should help verify that the fix is functional. It's here: #105153. |
UPD: it does work — https://github.com/python/cpython/actions/runs/5135145133/jobs/9240164159?pr=105153#step:5:17 cc @hugovk |
hugovk
reviewed
May 31, 2023
webknjaz
commented
Jun 4, 2023
webknjaz
commented
Jun 4, 2023
|
@hugovk I think this needs |
hugovk
reviewed
Jun 5, 2023
Co-authored-by: Hugo van Kemenade <[email protected]>
…6--get-changed-files--output-format
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 22, 2023
Co-authored-by: Hugo van Kemenade <[email protected]> (cherry picked from commit eaa6702)
webknjaz
added a commit
to webknjaz/cpython
that referenced
this pull request
Jul 22, 2023
Co-authored-by: Hugo van Kemenade <[email protected]> (cherry picked from commit eaa6702)
This was referenced Jul 22, 2023
ambv
pushed a commit
that referenced
this pull request
Jul 23, 2023
…) (#107043) Co-authored-by: Sviatoslav Sydorenko <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>. (cherry picked from commit 88d14da) (cherry picked from commit eaa6702)
ambv
pushed a commit
that referenced
this pull request
Jul 23, 2023
…) (#107042) Co-authored-by: Sviatoslav Sydorenko <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> (cherry picked from commit 88d14da) (cherry picked from commit eaa6702)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because paths with whitespaces tend to crash said
action[1][2][3]. Also, we don't need to use JSON as it's harder
to parse while the value isn't used except for the emptiness check.
The change fixes [4]. It also reverts commit 4c77061.