Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103092: Isolate ctypes #103612

Closed
wants to merge 6 commits into from
Closed

gh-103092: Isolate ctypes #103612

wants to merge 6 commits into from

Conversation

aisk
Copy link
Member

@aisk aisk commented Apr 18, 2023 •
edited
Loading

  • Using multi-phase initialization for _ctypes module
  • port PyCStructType_Type to heap type
  • port UnionType_Type to heap type
  • port PyCPointerType_Type to heap type
  • port PyCArrayType_Type to heap type
  • port PyCSimpleType_Type to heap type
  • port PyCFuncPtrType_Type to heap type
  • port Struct_Type to heap type
  • port Union_Type to heap type
  • port PyCPointer_Type to heap type
  • port PyCArray_Type to heap type
  • port Simple_Type to heap type
  • port PyCFuncPtr_Type to heap type
  • port PyCField_Type to heap type
  • port DictRemover_Type to heap type
  • port StructParam_Type to heap type
  • port PyComError_Type to heap type

@bedevere-bot bedevere-bot mentioned this pull request Apr 18, 2023
Open
25 tasks
@erlend-aasland
Copy link
Contributor

@aisk, are you basing your current _ctypes work off of this draft PR? If not, perhaps we should close it.

@aisk
Copy link
Member Author

aisk commented Jan 10, 2024

I was trying to enable multi-phase initialization and per-interpreter state, as well as convert some types to heap types in this PR. However, I found that the API to find a module state by type PyType_GetModuleByDef requires the parent type (or children? I forgot) to be converted first.

This made it much harder to finish, so I copied some code from this PR to #113620. Therefore, this should be closed now.

@aisk aisk closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aisk @erlend-aasland @bedevere-bot