Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent test failures in test test_asyncio.test_streams.test_drain_raises on Windows #98703

Closed
Fidget-Spinner opened this issue Oct 26, 2022 · 5 comments
Closed

Consistent test failures in test test_asyncio.test_streams.test_drain_raises on Windows #98703

Fidget-Spinner opened this issue Oct 26, 2022 · 5 comments
Assignees
@Fidget-Spinner
Labels
3.10 only security fixes 3.11 only security fixes 3.12 bugs and security fixes topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@Fidget-Spinner
Copy link
Member

Run python_d.exe -m test test_asyncio -m test_drain_raises -F on Windows. The test eventually fails after some repetitions.

The problem is that _call_connection_lost can be called multiple times, even after the socket by the proactortransport is closed. So it's calling close() on something that is already set to None.

I have a PR to fix it.
@Fidget-Spinner Fidget-Spinner added the type-bug An unexpected behavior, bug, or error label Oct 26, 2022
@bedevere-bot bedevere-bot mentioned this issue Oct 26, 2022
Merged
@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Oct 26, 2022 •
edited
Loading

@pablogsal sorry to bother you right after the monumental 3.11 release (thanks for that by the way!). However, I'm setting this as release blocker as it's causing the Windows Buildbots to occasionally fail https://buildbot.python.org/all/#/builders/146.

I have already created a PR to fix this.

@Fidget-Spinner Fidget-Spinner mentioned this issue Oct 26, 2022
Merged
@Fidget-Spinner Fidget-Spinner self-assigned this Oct 26, 2022
@pablogsal
Copy link
Member

Thanks a lot @Fidget-Spinner 🙏

@ezio-melotti ezio-melotti moved this to Todo in asyncio Oct 26, 2022
@kumaraditya303 kumaraditya303 added the 3.12 bugs and security fixes label Oct 26, 2022
@Fidget-Spinner Fidget-Spinner added the 3.11 only security fixes label Oct 26, 2022
@Fidget-Spinner Fidget-Spinner moved this from Todo to In Progress in Release and Deferred blockers 🚫 Oct 26, 2022
@kumaraditya303 kumaraditya303 added the 3.10 only security fixes label Oct 26, 2022
@bedevere-bot bedevere-bot mentioned this issue Oct 26, 2022
Merged
@gvanrossum
Copy link
Member

Does it needs to be a release blocker? Or just be backported?

@Fidget-Spinner
Copy link
Member Author

Does it needs to be a release blocker? Or just be backported?

It causes the release status page to flicker in and out of being releasable and non-releasable. That's a release blocker IMO.

Fidget-Spinner added a commit that referenced this issue Oct 27, 2022
@Fidget-Spinner @kumaraditya303
gh-98703: Fix asyncio proactor_events calling _call_connection_lost m…
8a75542 
…ultiple times (GH-98704)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Oct 27, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 27, 2022
@Fidget-Spinner @miss-islington
pythongh-98703: Fix asyncio proactor_events calling _call_connection_…
a4da65b 
…lost multiple times (pythonGH-98704)

Co-authored-by: Kumar Aditya <[email protected]>
(cherry picked from commit 8a75542)

Co-authored-by: Ken Jin <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Oct 27, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 27, 2022
@Fidget-Spinner @miss-islington
pythongh-98703: Fix asyncio proactor_events calling _call_connection_…
2a54ef6 
…lost multiple times (pythonGH-98704)

Co-authored-by: Kumar Aditya <[email protected]>
(cherry picked from commit 8a75542)

Co-authored-by: Ken Jin <[email protected]>
miss-islington added a commit that referenced this issue Oct 27, 2022
@miss-islington @Fidget-Spinner
gh-98703: Fix asyncio proactor_events calling _call_connection_lost m…
bb80f6a 
…ultiple times (GH-98704)

Co-authored-by: Kumar Aditya <[email protected]>
(cherry picked from commit 8a75542)

Co-authored-by: Ken Jin <[email protected]>
miss-islington added a commit that referenced this issue Oct 27, 2022
@miss-islington @Fidget-Spinner
gh-98703: Fix asyncio proactor_events calling _call_connection_lost m…
08ce791 
…ultiple times (GH-98704)

Co-authored-by: Kumar Aditya <[email protected]>
(cherry picked from commit 8a75542)

Co-authored-by: Ken Jin <[email protected]>
@Fidget-Spinner Fidget-Spinner moved this from In Progress to Done in Release and Deferred blockers 🚫 Oct 27, 2022
@Fidget-Spinner Fidget-Spinner moved this from Todo to Done in asyncio Oct 27, 2022
@Fidget-Spinner Fidget-Spinner moved this from Done to In Progress in asyncio Oct 27, 2022
@Fidget-Spinner
Copy link
Member Author

Waiting for Kumar's tests to land before I close this issue. It's no longer a release blocker though.

Fidget-Spinner pushed a commit that referenced this issue Oct 27, 2022
@kumaraditya303
gh-98703: Add tests for closing _ProactorSocketTransport with proac…
96ae80f 
…tor event loop (GH-98730)
@bedevere-bot bedevere-bot mentioned this issue Oct 27, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 27, 2022
@kumaraditya303 @miss-islington
pythongh-98703: Add tests for closing _ProactorSocketTransport with…
6869604 
… proactor event loop (pythonGH-98730)

(cherry picked from commit 96ae80f)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Oct 27, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 27, 2022
@kumaraditya303 @miss-islington
pythongh-98703: Add tests for closing _ProactorSocketTransport with…
0193292 
… proactor event loop (pythonGH-98730)

(cherry picked from commit 96ae80f)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit that referenced this issue Oct 27, 2022
@miss-islington @kumaraditya303
gh-98703: Add tests for closing _ProactorSocketTransport with proac…
8e475ad 
…tor event loop (GH-98730)

(cherry picked from commit 96ae80f)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit that referenced this issue Oct 27, 2022
@miss-islington @kumaraditya303
gh-98703: Add tests for closing _ProactorSocketTransport with proac…
9338e9a 
…tor event loop (GH-98730)

(cherry picked from commit 96ae80f)

Co-authored-by: Kumar Aditya <[email protected]>
Repository owner moved this from In Progress to Done in asyncio Oct 27, 2022
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Oct 28, 2022
@Fidget-Spinner @kumaraditya303 @gvanrossum
pythongh-98703: Fix asyncio proactor_events calling _call_connection_…
f8d9bb5 
…lost multiple times (pythonGH-98704)

Co-authored-by: Kumar Aditya <[email protected]>
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Oct 28, 2022
@kumaraditya303 @gvanrossum
pythongh-98703: Add tests for closing _ProactorSocketTransport with…
c66cd30 
… proactor event loop (pythonGH-98730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fidget-Spinner Fidget-Spinner

Labels
3.10 only security fixes 3.11 only security fixes 3.12 bugs and security fixes topic-asyncio type-bug An unexpected behavior, bug, or error
Projects
Release and Deferred blockers 🚫
Archived in project
asyncio
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gvanrossum @pablogsal @Fidget-Spinner @kumaraditya303