Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokenize.NL always exists, tabnanny thinks otherwise #97639

Closed
sobolevn opened this issue Sep 29, 2022 · 0 comments
Closed

tokenize.NL always exists, tabnanny thinks otherwise #97639

sobolevn opened this issue Sep 29, 2022 · 0 comments
Labels
tests Tests in the Lib/test dir

Comments

@sobolevn
Copy link
Member

While checking coverage of some module, I found that these condition is never True: https://github.com/python/cpython/blame/4652093e1b816b78e9a585d671a807ce66427417/Lib/tabnanny.py#L26-L27

Which is correct, because NL token is always there.
This code is pretty old, I think it is safe to be removed.
@sobolevn sobolevn added the tests Tests in the Lib/test dir label Sep 29, 2022
sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 29, 2022
@sobolevn
pythongh-97639: Remove tokenize.NL check from tabnanny
e20db8b
@sobolevn sobolevn mentioned this issue Sep 29, 2022
Merged
@miss-islington miss-islington mentioned this issue Oct 4, 2022
Merged
orsenthil pushed a commit that referenced this issue Oct 4, 2022
@sobolevn @blurb-it
gh-97639: Remove tokenize.NL check from tabnanny (#97640)
0601684 
* gh-97639: Remove `tokenize.NL` check from `tabnanny`

* 📜🤖 Added by blurb_it.

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 4, 2022
@sobolevn @miss-islington
pythongh-97639: Remove tokenize.NL check from tabnanny (pythonGH-…
768ce6a 
…97640)

* pythongh-97639: Remove `tokenize.NL` check from `tabnanny`

* 📜🤖 Added by blurb_it.

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 0601684)

Co-authored-by: Nikita Sobolev <[email protected]>
@miss-islington miss-islington mentioned this issue Oct 4, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 4, 2022
@sobolevn @miss-islington
pythongh-97639: Remove tokenize.NL check from tabnanny (pythonGH-…
de4e3dd 
…97640)

* pythongh-97639: Remove `tokenize.NL` check from `tabnanny`

* 📜🤖 Added by blurb_it.

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 0601684)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this issue Oct 4, 2022
@miss-islington @sobolevn
gh-97639: Remove tokenize.NL check from tabnanny (GH-97640)
40e56f3 
* gh-97639: Remove `tokenize.NL` check from `tabnanny`

* 📜🤖 Added by blurb_it.

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 0601684)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this issue Oct 4, 2022
@miss-islington @sobolevn
gh-97639: Remove tokenize.NL check from tabnanny (GH-97640)
0e3a046 
* gh-97639: Remove `tokenize.NL` check from `tabnanny`

* 📜🤖 Added by blurb_it.

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 0601684)

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orsenthil @sobolevn