Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 launcher fails with "Unable to create process" #95285

Closed
pfmoore opened this issue Jul 26, 2022 · 5 comments
Closed

Python 3.11 launcher fails with "Unable to create process" #95285

pfmoore opened this issue Jul 26, 2022 · 5 comments
Assignees
Labels
3.11 only security fixes OS-windows release-blocker type-bug An unexpected behavior, bug, or error

Comments

@pfmoore
Copy link
Member

pfmoore commented Jul 26, 2022

Bug report

When running a pip.pyz file with the py.exe launcher (itself launched from a Rust program), the command fails with the error:

Unable to create process using 'C:\Users\Gustav\AppData\Local\Programs\Python\Python311\"py C:\Users\Gustav\.local\apps\pip.pyz --version': The system cannot find the file specified.

Unfortunately, I haven't been able to isolate a fully reproducible test case so far. However, I have set $env:PYLAUNCHER_DEBUG=1 and the output of the failing command is

❯ pip --version
argv0: py.exe
version: 3.11.0b5
# Read 4096 bytes from C:\Users\Gustav\.local\apps\pip.pyz to find shebang line
Shebang: /usr/bin/env python
# Reading from C:\Users\Gustav\AppData\Local\py.ini for commands/python
# Did not find file C:\Users\Gustav\AppData\Local\py.ini
# Reading from C:\WINDOWS\py.ini for commands/python
# Did not find file C:\WINDOWS\py.ini
# Treating shebang command 'python' as 'py'
SearchInfo.originalCmdLine: "py.exe" C:\Users\Gustav\.local\apps\pip.pyz --version
SearchInfo.restOfCmdLine:  C:\Users\Gustav\.local\apps\pip.pyz --version
SearchInfo.executablePath: (null)
SearchInfo.scriptFile: C:\Users\Gustav\.local\apps\pip.pyz
SearchInfo.executable: "py
SearchInfo.executableArgs:
SearchInfo.company: (null)
SearchInfo.tag: (empty)
SearchInfo.oldStyleTag: True
SearchInfo.lowPriorityTag: False
SearchInfo.exclude32Bit: False
SearchInfo.only32Bit: False
SearchInfo.allowDefaults: False
SearchInfo.allowExecutableOverride: False
SearchInfo.windowed: False
SearchInfo.list: False
SearchInfo.listPaths: False
SearchInfo.help: False
 -V:3.11          C:\Users\Gustav\AppData\Local\Programs\Python\Python311\python.exe
 -V:3.10          C:\Users\Gustav\AppData\Local\Programs\Python\Python310\python.exe
 -V:3.9           C:\Users\Gustav\AppData\Local\Programs\Python\Python39\python.exe
 -V:3.8           C:\Users\Gustav\AppData\Local\Programs\Python\Python38\python.exe
env.company: PythonCore
env.tag: 3.11
# about to run: C:\Users\Gustav\AppData\Local\Programs\Python\Python311\"py C:\Users\Gustav\.local\apps\pip.pyz --version
Unable to create process using 'C:\Users\Gustav\AppData\Local\Programs\Python\Python311\"py C:\Users\Gustav\.local\apps\pip.pyz --version': The system cannot find the file specified.

The key issue seems to be

SearchInfo.executable: "py

(note the unbalanced quotes) which appears to be a result of incorrectly parsing the following:

SearchInfo.originalCmdLine: "py.exe" C:\Users\Gustav\.local\apps\pip.pyz --version

I can create the same debug output using the internal _winapi.CreateProcess function:

_winapi.CreateProcess("C:/Windows/py.exe", '"py.exe" -0', None, None, 0, 0, None, None, 0)

So the problem appears to be when the command line passed to CreateProcess contains a double quoted but relative filename.

Your environment

  • Python and launcher from 3.11.0b5.
  • Operating system and architecture: Windows 11, 64-bit.
@pfmoore pfmoore added the type-bug An unexpected behavior, bug, or error label Jul 26, 2022
@pfmoore
Copy link
Member Author

pfmoore commented Jul 26, 2022 •
edited
Loading

Maybe another release blocker?

Edit: Possibly not - I rebuilt my Rust program, and cannot reproduce the issue there, now. So while there is definitely an issue, it's not as easily triggerable as I first thought. I updated my copy of rust, so maybe the rust stdlib changed how it calls CreateProcess?

@pfmoore pfmoore added 3.11 only security fixes OS-windows labels Jul 26, 2022
@mrabarnett
Copy link

I notice that there's a stray quote in that first example: ... \Python311\"py ...

Was that a typo or actually present?

@pfmoore
Copy link
Member Author

pfmoore commented Jul 26, 2022

Actually present. I'm assuming it comes from treating SearchInfo.executable: "py as relative and prepending a directory to it...

Copy link
Member

Yeah, something funky going on with the shebang command there it looks like. I'll take a look

Copy link
Member

Okay, seems it's actually argv0 processing that's off, and you need to be launching from cmd.exe to trigger it (or probably through a custom subprocess command).

Jul 26, 2022
pythongh-95285: py.exe launcher fails with short argv0
4716934
@bedevere-bot bedevere-bot mentioned this issue Jul 26, 2022
Merged
Jul 26, 2022
gh-95285: py.exe launcher fails with short argv0 (GH-95295)
7ac5bb3
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 26, 2022
@miss-islington
pythongh-95285: py.exe launcher fails with short argv0 (pythonGH-95295)
577607f 
(cherry picked from commit 7ac5bb3)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Jul 26, 2022
Merged
ambv pushed a commit that referenced this issue Jul 27, 2022
@miss-islington
gh-95285: py.exe launcher fails with short argv0 (GH-95295) (GH-95298)
7df3a1c 
(cherry picked from commit 7ac5bb3)

Co-authored-by: Steve Dower <[email protected]>
Repository owner moved this from Todo to Done in Release and Deferred blockers 🚫 Jul 29, 2022
@kai2nenobu kai2nenobu mentioned this issue Nov 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

zooba

Labels
3.11 only security fixes OS-windows release-blocker type-bug An unexpected behavior, bug, or error
Projects
Release and Deferred blockers 🚫
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pfmoore @mrabarnett