Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

email.Utils.parseaddr fails to parse valid addresses #40889

Open
melicertes mannequin opened this issue Sep 9, 2004 · 10 comments · May be fixed by #123311
Open

email.Utils.parseaddr fails to parse valid addresses #40889

melicertes mannequin opened this issue Sep 9, 2004 · 10 comments · May be fixed by #123311
Labels
stdlib Python modules in the Lib dir topic-email type-bug An unexpected behavior, bug, or error

Comments

@melicertes
Copy link
Mannequin

melicertes mannequin commented Sep 9, 2004 •
edited by bedevere-app bot
Loading

BPO 1025395
Nosy @warsaw, @tiran, @merwok, @bitdancer, @vadmium, @thehesiod, @ioanatia
PRs
  • bpo-1025395: Fix email.utils.parseaddr to handle multiple hops #142
  • bpo-1025395: Fix email.utils.parseaddr to handle multiple hops #6917
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2004-09-09.20:43:42.000>
labels = ['3.7', 'type-bug', 'library', 'expert-email']
title = 'email.Utils.parseaddr fails to parse valid addresses'
updated_at = <Date 2018-05-16.19:01:00.100>
user = 'https://bugs.python.org/melicertes'

    bugs.python.org fields:

    activity = <Date 2018-05-16.19:01:00.100>
actor = 'ioanatia'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)', 'email']
creation = <Date 2004-09-09.20:43:42.000>
creator = 'melicertes'
dependencies = []
files = []
hgrepos = []
issue_num = 1025395
keywords = ['patch']
message_count = 10.0
messages = ['22413', '59669', '59670', '59671', '59735', '59737', '59751', '59753', '301485', '301504']
nosy_count = 10.0
nosy_names = ['barry', 'melicertes', 'christian.heimes', 'sdgathman', 'eric.araujo', 'r.david.murray', 'sascha_silbe', 'martin.panter', 'thehesiod', 'ioanatia']
pr_nums = ['142', '6917']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1025395'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.6', 'Python 3.7']

    Linked PRs
    @melicertes
    Copy link
    Mannequin Author

    melicertes mannequin commented Sep 9, 2004

    email.Utils.parseaddr() does not successfully parse a
    field value into a (comment, address) pair if the
    address contains a source route with more than one hop.

    i.e., it is successfully parses this:

    "God" <@hop1.org:[email protected]>

    to get the address <[email protected]>, but it fails to do
    the same if supplied with a 2-hop source route:

    "God" <@hop1.org,@hop2.net:[email protected]>

    In this case, it gets the comment ("God") right, but
    fails to extract the address.

    Multi-hop source routes, while deprecated, are still
    valid in rfc2822.

    @melicertes melicertes mannequin assigned warsaw Sep 9, 2004
    @melicertes melicertes mannequin added the stdlib Python modules in the Lib dir label Sep 9, 2004
    @melicertes melicertes mannequin assigned warsaw Sep 9, 2004
    @melicertes melicertes mannequin added the stdlib Python modules in the Lib dir label Sep 9, 2004
    @sdgathman sdgathman mannequin added type-bug An unexpected behavior, bug, or error labels Jan 10, 2008
    @sdgathman
    Copy link
    Mannequin

    sdgathman mannequin commented Jan 10, 2008

    # A quick and very dirty fix for common broken cases, with test cases.

    import rfc822

def parseaddr(t):
  """Split email into Fullname and address.
      >>> parseaddr('[email protected]')
  ('', '[email protected]')
  >>> parseaddr('"Full Name" <[email protected]>')
  ('Full Name', '[email protected]')
  >>> parseaddr('[email protected] <[email protected]>')
  ('[email protected]', '[email protected]')
  >>> parseaddr('"God" <@hop1.org,@hop2.net:[email protected]>')
  ('God', '[email protected]')
  """
  #return email.Utils.parseaddr(t)
  res = rfc822.parseaddr(t)
  # dirty fix for some broken cases
  if not res[0]:
    pos = t.find('<')
    if pos > 0 and t[-1] == '>':
      addrspec = t[pos+1:-1]
      pos1 = addrspec.rfind(':')
      if pos1 > 0:
        addrspec = addrspec[pos1+1:]
      return rfc822.parseaddr('"%s" <%s>' % (t[:pos].strip(),addrspec))
  if not res[1]:
    pos = t.find('<')
    if pos > 0 and t[-1] == '>':
      addrspec = t[pos+1:-1]
      pos1 = addrspec.rfind(':')
      if pos1 > 0:
        addrspec = addrspec[pos1+1:]
      return rfc822.parseaddr('%s<%s>' % (t[:pos].strip(),addrspec))
  return res

    @sdgathman
    Copy link
    Mannequin

    sdgathman mannequin commented Jan 10, 2008

    Ok, I see the '@' is technically not allowed in an atom. But it either
    needs to throw an invalid syntax exception, or heuristically return
    something reasonable.

    @sdgathman
    Copy link
    Mannequin

    sdgathman mannequin commented Jan 10, 2008

    Repeating because previous real life test case was rejected as 'spam':

    It also fails to parse:
>>> from email.Utils import parseaddr
>>> parseaddr('[email protected] <[email protected]>')
('', '[email protected]')

    Getting the wrong part as the actual email to boot! Checked 2.4 and 2.5.

    @sdgathman
    Copy link
    Mannequin

    sdgathman mannequin commented Jan 11, 2008

    Same or related issues: bpo-1221, bpo-1409460

    @sdgathman
    Copy link
    Mannequin

    sdgathman mannequin commented Jan 11, 2008 

    Test cases so far:
  >>> parseaddr('[email protected]')
  ('', '[email protected]')
  >>> parseaddr('"Full Name" <[email protected]>')
  ('Full Name', '[email protected]')
  >>> parseaddr('[email protected] <[email protected]>')
  ('[email protected]', '[email protected]')
  >>> parseaddr('God@heaven <@hop1.org,@hop2.net:[email protected]>')
  ('God@heaven', '[email protected]')
  >>> parseaddr('Real Name ((comment)) <[email protected]>')
  ('Real Name', '[email protected]')
  >>> parseaddr('a(WRONG)@b')
  ('', 'a@b')

    Copy link
    Member

    An example from bpo-1221:

    >>> email.Utils.parseaddr("a(WRONG)@b")
('WRONG WRONG', 'a@b')

    @sdgathman
    Copy link
    Mannequin

    sdgathman mannequin commented Jan 11, 2008

    tiran: yes, but that is the wrong answer, and that example is already in
    the testcase list (with what I believe is the right answer).

    @warsaw warsaw assigned bitdancer and unassigned warsaw May 5, 2010
    @bitdancer bitdancer removed their assignment May 16, 2012
    @bitdancer bitdancer removed their assignment May 16, 2012
    @thehesiod thehesiod mannequin added 3.7 (EOL) end of life labels Sep 6, 2017
    @thehesiod
    Copy link
    Mannequin

    thehesiod mannequin commented Sep 6, 2017 

    from 3.6:
>>> AddrlistClass('John Smith <john.smith(comment)@example.org>').getcomment()
''

>>> AddrlistClass('John Smith <john.smith(comment)@example.org>').getdomain()
'JohnSmith'

    totally messed up :)

    @thehesiod
    Copy link
    Mannequin

    thehesiod mannequin commented Sep 6, 2017

    looks like these were meant to be internal methods, retracting new issues

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    crazymerlyn added a commit to crazymerlyn/cpython that referenced this issue Aug 25, 2024
    @crazymerlyn
    pythongh-40889: Fix email.utils.parseaddr to handle multiple hops
    59bf3dc
    @crazymerlyn crazymerlyn linked a pull request Aug 25, 2024 that will close this issue
    Open
    crazymerlyn added a commit to crazymerlyn/cpython that referenced this issue Aug 25, 2024
    @crazymerlyn
    pythongh-40889: Fix email.utils.parseaddr to handle multiple hops
    4e4bf6b
    @picnixz picnixz removed the 3.7 (EOL) end of life label Aug 25, 2024
    crazymerlyn added a commit to crazymerlyn/cpython that referenced this issue Aug 25, 2024
    @crazymerlyn
    pythongh-40889: Fix email.utils.parseaddr to handle multiple hops
    d774051
    crazymerlyn added a commit to crazymerlyn/cpython that referenced this issue Aug 25, 2024
    @crazymerlyn
    pythongh-40889: Fix email.utils.parseaddr to handle routes with mul…
    6d54215 
    …tiple intermediate hops
    crazymerlyn added a commit to crazymerlyn/cpython that referenced this issue Aug 25, 2024
    @crazymerlyn
    pythongh-40889: Fix email.utils.parseaddr to handle routes with mul…
    3491233 
    …tiple intermediate hops
    crazymerlyn added a commit to crazymerlyn/cpython that referenced this issue Aug 25, 2024
    @crazymerlyn
    pythongh-40889: Fix email.utils.parseaddr to handle routes with mul…
    bc29cb9 
    …tiple intermediate hops
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir topic-email type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging a pull request may close this issue.

    gh-40889: Fix email.utils.parseaddr to handle multiple hops crazymerlyn/cpython
    4 participants
    @warsaw @bitdancer @picnixz