-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency between file names of SyntaxErrors and other Exceptions in the new repl #122546
Labels
3.13
bugs and security fixes
3.14
new features, bugs and security fixes
topic-repl
Related to the interactive shell
Comments
AlexWaygood
added
3.13
bugs and security fixes
3.14
new features, bugs and security fixes
labels
Aug 1, 2024
skirpichev
added a commit
to skirpichev/cpython
that referenced
this issue
Aug 22, 2024
pr is ready: #123217 |
pablogsal
pushed a commit
that referenced
this issue
Aug 22, 2024
skirpichev
added a commit
to skirpichev/cpython
that referenced
this issue
Aug 22, 2024
… new repl (pythonGH-123217) * pythongh-122546: use same filename for different exceptions in new repl * +1 (cherry picked from commit 3d7b1a5) Co-authored-by: Sergey B Kirpichev <[email protected]>
there's another form of the bug, with >>> b
File "<unknown>", line 1
b
IndentationError: unexpected indent |
skirpichev
added a commit
to skirpichev/cpython
that referenced
this issue
Aug 22, 2024
Yes, we should use less strict type check. Correction: #123233. |
pablogsal
pushed a commit
that referenced
this issue
Aug 22, 2024
pablogsal
pushed a commit
that referenced
this issue
Aug 22, 2024
pablogsal
pushed a commit
to pablogsal/cpython
that referenced
this issue
Aug 22, 2024
…n the new REPL (pythonGH-123233) (cherry picked from commit 4c3f0cb) Co-authored-by: Sergey B Kirpichev <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Aug 23, 2024
…ew REPL (pythonGH-123233) (cherry picked from commit 4c3f0cb) Co-authored-by: Sergey B Kirpichev <[email protected]>
I think we are done. Please reopen if we missed anything. Thanks @skirpichev for the PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3.13
bugs and security fixes
3.14
new features, bugs and security fixes
topic-repl
Related to the interactive shell
A small issue, but the new repl reports
<unknown>
as the file name forSyntaxErrors
, but<python-input-x>
for other errors:Classic repl:
I think this is because
_pyrepl.console.InteractiveColoredConsole.showsyntaxerror
does not pass on thefilename
argument to the super method:Should probably wait till #122528 is done. Then,
InteractiveColoredConsole
could be simplified to overwrite only_showtraceback
. The undocumented colorize keyword arguments thatshowtraceback
andshowsyntaxerror
have gained for pyrepl could be removed again.Linked PRs
The text was updated successfully, but these errors were encountered: