Functional version of evcurve workflow #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamhuber
reviewed
Apr 24, 2024
|
|
||
| def get_strains( | ||
| vol_range: Optional[float], | ||
| num_points: Optional[int], |
There was a problem hiding this comment.
It is either vol_range and num_points or strain_lst.
There was a problem hiding this comment.
It categorically is not. The code as written does not allow vol_range and num_points to be optional. It is vol_range and num_points, or vol_range and num_points (both ignored) and strain_list.
>>> from atomistics.workflows.evcurve.helper import get_strains
>>>
>>> get_strains(strain_lst=[1,2,3])
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
Cell In[6], line 3
1 from atomistics.workflows.evcurve.helper import get_strains
----> 3 get_strains(strain_lst=[1,2,3])
TypeError: get_strains() missing 2 required positional arguments: 'vol_range' and 'num_points'You've placed two purely positional arguments with no default and then hinted them as optional.
There was a problem hiding this comment.
This is now addressed in #252
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.