Only run CI builds once per PR #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/view-components/B7mQ4TC7kh8Mvs6kFyZswgLC79sS |
manuelpuyol
reviewed
May 5, 2021
.github/workflows/ci.yml
Outdated
Comment on lines
3
to
7
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
I'm 99% sure we needed both push and PR because of forks
There was a problem hiding this comment.
We can use pull_request_target which is what I do on primer/css that will run on forks
There was a problem hiding this comment.
Example here primer/css#1357
manuelpuyol
previously approved these changes
May 5, 2021
uh oh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was noticing that the CI builds run twice per Pull Request.
This PR updates the action script to run on pushes on main and any commits to a pr.