Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketing: use size modifiers that don't look like breakpoints modifiers #1380

Merged
merged 3 commits into from
May 6, 2021

Conversation

tobiasahlin
Copy link
Contributor

The .btn-lg-mktg and .btn-sm-mktg utility classes make buttons larger and smaller, but they can at a glance look like they will only apply a button style from lg and sm breakpoints and upwards. This PR updates these classes to be called .btn-large-mktg and .btn-small-mktg instead, to reduce similarity with the breakpoint modifiers.

@tobiasahlin tobiasahlin requested a review from simurai May 5, 2021 10:35
@changeset-bot
Copy link

changeset-bot bot commented May 5, 2021

🦋 Changeset detected

Latest commit: d3d0bba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! 🚢👍

@simurai simurai merged commit d7209ce into main May 6, 2021
@simurai simurai deleted the tobiasahlin/dont-confuse-sizes-with-breakpoints branch May 6, 2021 08:35
@primer-css primer-css mentioned this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants