Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typography-base: process 'type' attribute of HTML <ol> tag #1357

Merged
merged 5 commits into from
Apr 27, 2021
Merged

typography-base: process 'type' attribute of HTML <ol> tag #1357

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
729a161
typography-base: process 'type' attribute of HTML <ol> tag
hpalacio Apr 23, 2021
1074565
Update lists.scss
jonrohan Apr 27, 2021
7be59c3
Update typography-base.scss
jonrohan Apr 27, 2021
3dfb910
Create odd-foxes-invite.md
jonrohan Apr 27, 2021
42ebe55
Merge branch 'main' into hpalacio/ol_type
jonrohan Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
typography-base: process 'type' attribute of HTML <ol> tag 
Some markup languages like AsciiDoc, allow defining the 'type'
attribute of HTML <ol> tag.
For instance, the following AsciiDoc code:

	[loweralpha]
	. item1
	. item2

Produces in GitHub the HTML code:

	<ol type="a">
		<li>item1</li>
		<li>item2</li>
	</ol>

The current SCSS doesn't cover this 'type' attribute, so the regular
default symbol (decimal) applies, instead of the one intended by the
author.

Signed-off-by: Hector Palacios <[email protected]>
  • Loading branch information
@hpalacio
hpalacio committed Apr 23, 2021
commit 729a16161615c16def3ba2b2301450661d076974
12 changes: 12 additions & 0 deletions src/base/typography-base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,18 @@ ol ol ol {
list-style-type: lower-alpha;
}

ol[type="1"] {
list-style-type: decimal;
}

ol[type="a"] {
list-style-type: lower-alpha;
}

ol[type="i"] {
list-style-type: lower-roman;
}

dd {
margin-left: 0;
}
Expand Down