Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript: Fix broken format for ...infer T #9044

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Typescript: Fix broken format for ...infer T #9044

merged 1 commit into from
Aug 25, 2020

Conversation

fisker
Copy link
Member

@fisker fisker commented Aug 25, 2020

Fixes #9041

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker force-pushed the issue-9041 branch 2 times, most recently from 3ba06bb to 204f9aa Compare August 25, 2020 04:48
@fisker fisker changed the title Remove parens around TSInferType Fix broken format for ...infer T Aug 25, 2020
@fisker fisker changed the title Fix broken format for ...infer T Typescript: Fix broken format for ...infer T Aug 25, 2020
@alexander-akait alexander-akait merged commit 9a9dcbe into prettier:master Aug 25, 2020
@alexander-akait
Copy link
Member

I think patch release will be good idea

@fisker fisker deleted the issue-9041 branch August 25, 2020 09:38
@fisker fisker mentioned this pull request Aug 25, 2020
Closed
6 tasks
@brodycj brodycj mentioned this pull request Aug 25, 2020
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

@thorn0 thorn0 thorn0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prettier 2.1.0 generates broken code with new ...infer T syntax in TypeScript 4.0
4 participants
@fisker @alexander-akait @thorn0 @sosukesuzuki