-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniform line endings for multi line strings/comments #7891
Conversation
* Removed double parsing of the doc * Moved newline check to printDocToString
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the test case to original code from #6501
How does this work with e.g. template strings containing LFs? Does it preserve them or does it change their content? |
console.log(
`Multiline \n string\
Multiline string\
Multiline string`
); Will have the I've updated the test case to cover this. |
@thorn0 any pointers on how to handle the codecov failure? |
@sidharthv96 Failing because of "+-0.01%" looks like a misconfiguration. Ignore it. |
@j-f1 I think your question was about non-escaped line breaks in template literals. So I did a little research. Turns out (see the spec) template literals treat any LineTerminatorSequence as LF, no matter how it's represented in the source code: In other words, |
@sidharthv96 Thanks for fixing this! |
Fixes #6501
changelog_unreleased/*/pr-XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨