-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline _ or $ in the root of a method chain #4621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function isFactory(name) { | ||
return /^[A-Z]/.test(name); | ||
return /^[A-Z]|^[_$]+$/.test(name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add test with $
to avoid regression in future?
alexander-akait
approved these changes
Jun 1, 2018
j-f1
approved these changes
Jun 1, 2018
suchipi
approved these changes
Jun 1, 2018
@suchipi @evilebottnawi @j-f1 Do you think we should release Prettier 1.13.5 ? |
Let's wait a day or two and see if anything else comes up |
bors bot
referenced
this pull request
in mozilla/delivery-console
Jun 8, 2018
185: Update dependency prettier to v1.13.5 r=rehandalal a=renovate[bot] This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.4` to `v1.13.5` <details> <summary>Release Notes</summary> ### [`v1.13.5`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#​1135) [Compare Source](prettier/prettier@1.13.4...1.13.5) [link](prettier/prettier@1.13.4...1.13.5) - Better handling of trailing spaces in Markdown ([#​4593](`https://github.com/prettier/prettier/pull/4593`)) - Fix empty file error in JSON and GraphQL ([#​4553](`https://github.com/prettier/prettier/pull/4553`)) - Preserve decorator on TypeScript interfaces ([#​4632](`https://github.com/prettier/prettier/pull/4632`)) - Inline \_ or $ in the root of a method chain ([#​4621](`https://github.com/prettier/prettier/pull/4621`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <[email protected]>
peterbe
referenced
this pull request
in mozilla-services/tecken
Jun 22, 2018
This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.4` to `v1.13.5` <details> <summary>Release Notes</summary> ### [`v1.13.5`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#​1135) [Compare Source](prettier/prettier@1.13.4...1.13.5) [diff](prettier/prettier@1.13.4...1.13.5) - Better handling of trailing spaces in Markdown ([#​4593](`https://github.com/prettier/prettier/pull/4593`)) - Fix empty file error in JSON and GraphQL ([#​4553](`https://github.com/prettier/prettier/pull/4553`)) - Preserve decorator on TypeScript interfaces ([#​4632](`https://github.com/prettier/prettier/pull/4632`)) - Inline \_ or $ in the root of a method chain ([#​4621](`https://github.com/prettier/prettier/pull/4621`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
locked-due-to-inactivity
Please open a new issue and fill out the template instead of commenting.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4614