Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline _ or $ in the root of a method chain #4621

Merged
merged 2 commits into from
Jun 1, 2018

Conversation

duailibe
Copy link
Member

@duailibe duailibe commented Jun 1, 2018

Closes #4614

function isFactory(name) {
return /^[A-Z]/.test(name);
return /^[A-Z]|^[_$]+$/.test(name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add test with $ to avoid regression in future?

@duailibe duailibe merged commit a4da6e6 into prettier:master Jun 1, 2018
@duailibe duailibe deleted the factories branch June 1, 2018 15:51
@duailibe
Copy link
Member Author

duailibe commented Jun 1, 2018

@suchipi @evilebottnawi @j-f1 Do you think we should release Prettier 1.13.5 ?

@suchipi
Copy link
Member

suchipi commented Jun 1, 2018

Let's wait a day or two and see if anything else comes up

bors bot referenced this pull request in mozilla/delivery-console Jun 8, 2018
185: Update dependency prettier to v1.13.5 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.4` to `v1.13.5`



<details>
<summary>Release Notes</summary>

### [`v1.13.5`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1135)
[Compare Source](prettier/prettier@1.13.4...1.13.5)
[link](prettier/prettier@1.13.4...1.13.5)

- Better handling of trailing spaces in Markdown ([#&#8203;4593](`https://github.com/prettier/prettier/pull/4593`))
- Fix empty file error in JSON and GraphQL ([#&#8203;4553](`https://github.com/prettier/prettier/pull/4553`))
- Preserve decorator on TypeScript interfaces ([#&#8203;4632](`https://github.com/prettier/prettier/pull/4632`))
- Inline \_ or $ in the root of a method chain ([#&#8203;4621](`https://github.com/prettier/prettier/pull/4621`))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <[email protected]>
peterbe referenced this pull request in mozilla-services/tecken Jun 22, 2018
This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.4` to `v1.13.5`



<details>
<summary>Release Notes</summary>

### [`v1.13.5`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1135)
[Compare Source](prettier/prettier@1.13.4...1.13.5)
[diff](prettier/prettier@1.13.4...1.13.5)

- Better handling of trailing spaces in Markdown ([#&#8203;4593](`https://github.com/prettier/prettier/pull/4593`))
- Fix empty file error in JSON and GraphQL ([#&#8203;4553](`https://github.com/prettier/prettier/pull/4553`))
- Preserve decorator on TypeScript interfaces ([#&#8203;4632](`https://github.com/prettier/prettier/pull/4632`))
- Inline \_ or $ in the root of a method chain ([#&#8203;4621](`https://github.com/prettier/prettier/pull/4621`))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Aug 30, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants