fix(javascript): regression for hasOwnProperty
#4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duailibe
reviewed
May 30, 2018
src/language-js/printer-estree.js
Outdated
| "flow", // Lodash | ||
| "flowRight", // Lodash | ||
| "connect" // Redux | ||
| ]; |
There was a problem hiding this comment.
We used an object here specifically to prevent calling indexOf. I suggest we use Object.create(null), Map or a Set
duailibe
approved these changes
May 30, 2018
j-f1
approved these changes
May 30, 2018
hasOwnPropertyhasOwnProperty
|
@ikatyang Thanks for the super fast fix 🏁🏎👏 |
alexander-akait
approved these changes
May 30, 2018
lydell
approved these changes
May 30, 2018
| flowRight: true, // Lodash | ||
| connect: true // Redux | ||
| }; | ||
| const functionCompositionFunctionNames = new Set([ |
There was a problem hiding this comment.
Hehe, I proposed using a Set in the original PR :)
|
I'm not sure when but we should make these regression fixes available as soon as possible. And it seems Jest also encountered this issue jestjs/jest#6344 (comment). @duailibe what do you think? |
|
@ikatyang makes sense. I'll release 1.13.3 |
bors bot
referenced
this pull request
in mozilla/delivery-console
May 30, 2018
172: Update dependency prettier to v1.13.3 r=rehandalal a=renovate[bot] This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.2` to `v1.13.3` <details> <summary>Release Notes</summary> ### [`v1.13.3`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#​1133) [Compare Source](prettier/prettier@1.13.2...75e86b9) [link](prettier/prettier@1.13.2...1.13.3) - Fix a regression when printing `hasOwnProperty` and other functions in `Object`'s prototype ([#​4603](`https://github.com/prettier/prettier/pull/4603`)) - Fix a regression in exit status when using `--debug-check` and `--list-different` ([#​4600](https://github.com/prettier/prettier/pul/4600)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <[email protected]>
This was referenced May 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4602