Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix less/scss format error #12536

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Fix less/scss format error #12536

merged 2 commits into from
Mar 29, 2022

Conversation

fisker
Copy link
Member

@fisker fisker commented Mar 25, 2022

Description

Fixes #12504

value-paren_group seems missing location info, we should fix the ast, but I'm going to ignore them for now.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@@ -924,15 +924,16 @@ function genericPrint(path, options, print) {
if (
!isLast &&
child.type === "value-comma_group" &&
child.groups &&
child.groups[0].type !== "value-paren_group" &&
Copy link
Member Author

@fisker fisker Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this line is added for the same reason. Added in #12210

@fisker fisker marked this pull request as ready for review March 25, 2022 10:30
@dumbravaandrei22
Copy link

👍

@fisker fisker merged commit b429cee into prettier:main Mar 29, 2022
@fisker fisker deleted the 12504 branch March 29, 2022 12:44
sosukesuzuki pushed a commit that referenced this pull request Apr 2, 2022
sosukesuzuki pushed a commit that referenced this pull request Apr 2, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Apr 4, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [prettier](https://prettier.io) ([source](https://github.com/prettier/prettier)) | devDependencies | patch | [`2.6.1` -> `2.6.2`](https://renovatebot.com/diffs/npm/prettier/2.6.1/2.6.2) |

---

### Release Notes

<details>
<summary>prettier/prettier</summary>

### [`v2.6.2`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#&#8203;262)

[Compare Source](prettier/prettier@2.6.1...2.6.2)

[diff](prettier/prettier@2.6.1...2.6.2)

##### Fix LESS/SCSS format error ([#&#8203;12536](prettier/prettier#12536) by [@&#8203;fisker](https://github.com/fisker))

<!-- prettier-ignore -->

```less
// Input
.background-gradient(@&#8203;cut) {
    background: linear-gradient(
        to right,
        @&#8203;white 0%,
        @&#8203;white (@&#8203;cut - 0.01%),
        @&#8203;portal-background @&#8203;cut,
        @&#8203;portal-background 100%
    );
}

// Prettier 2.6.1
TypeError: Cannot read properties of undefined (reading 'endOffset')

// Prettier 2.6.2
.background-gradient(@&#8203;cut) {
  background: linear-gradient(
    to right,
    @&#8203;white 0%,
    @&#8203;white (@&#8203;cut - 0.01%),
    @&#8203;portal-background @&#8203;cut,
    @&#8203;portal-background 100%
  );
}
```

##### Update `meriyah` to fix several bugs ([#&#8203;12567](prettier/prettier#12567) by [@&#8203;fisker](https://github.com/fisker), fixes in [`meriyah`](https://github.com/meriyah/meriyah/) by [@&#8203;3cp](https://github.com/3cp))

Fixes bugs when parsing following valid code:

```js
foo(await bar());
```

```js
const regex = /.*/ms;
```

```js
const element = <p>{/w/.test(s)}</p>;
```

```js
class A extends B {
  #privateMethod() {
    super.method();
  }
}
```

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1280
Reviewed-by: 6543 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
jneander pushed a commit to jneander/prettier that referenced this pull request Dec 1, 2022
Empty lines between SCSS maps nested within other maps are not being
preserved by prettier. This resolves that.

No issue was found for this particular bug. As a reference, it relates
to prettier#12536, which mentioned the issue via code comment and in the pull
request.
jneander pushed a commit to jneander/prettier that referenced this pull request Dec 1, 2022
Empty lines between SCSS maps nested within other maps are not being
preserved by prettier. This resolves that.

No issue was found for this particular bug. As a reference, it relates
to prettier#12536, which mentioned the issue via code comment and in the pull
request.
jneander pushed a commit to jneander/prettier that referenced this pull request Dec 1, 2022
Empty lines between SCSS maps nested within other maps are not being
preserved by prettier. This resolves that.

No issue was found for this particular bug. As a reference, it relates
to prettier#12536, which mentioned the issue via code comment and in the pull
request.
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'endOffset')
4 participants