Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when bundle prettier with webpack #12511

Merged
merged 5 commits into from
Mar 24, 2022
Merged

Fix error when bundle prettier with webpack #12511

merged 5 commits into from
Mar 24, 2022

Conversation

fisker
Copy link
Member

@fisker fisker commented Mar 23, 2022 •
edited
Loading

Description

Error before this fix https://github.com/prettier/prettier/runs/5654297511?check_suite_focus=true#step:6:38

Fixes #12493

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker mentioned this pull request Mar 23, 2022
Closed
4 tasks
@fisker fisker changed the title Add test for #12493 [WIP] Fix 12493 Mar 23, 2022
@fisker fisker changed the title [WIP] Fix 12493 Fix error when bundle prettier with webpack Mar 23, 2022
@fisker fisker mentioned this pull request Mar 23, 2022
Closed
@fisker fisker marked this pull request as ready for review March 23, 2022 04:05
@sosukesuzuki
Copy link
Member

Should we release patch version for this?

@fisker
Copy link
Member Author

fisker commented Mar 23, 2022

I think we should, it's blocking webpack users to upgrade.

@sosukesuzuki
Copy link
Member

👍

@sosukesuzuki
Copy link
Member

Let's merge?

@fisker fisker merged commit 6664253 into prettier:main Mar 24, 2022
@fisker fisker deleted the 12493-2 branch March 24, 2022 03:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Cr(...).__exportStar is not a function
2 participants
@fisker @sosukesuzuki