Make options argument in parsers optional
#11892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duailibe
approved these changes
Dec 1, 2021
|
@fisker Sorry after merged, it is good to have changelog for this change. |
4 tasks
|
I think we should not encourage people use the parsers directly, but make sense to add changelog says we fixed the jest issue, is it fine? |
|
Yes, It would be better for users to know that this fixes the problem with jest. (Of course, I don't want a user to use the parser directly...) |
fisker
added a commit
to fisker/prettier
that referenced
this pull request
Dec 2, 2021
sosukesuzuki
pushed a commit
that referenced
this pull request
Dec 3, 2021
sosukesuzuki
pushed a commit
that referenced
this pull request
Dec 4, 2021
sosukesuzuki
pushed a commit
that referenced
this pull request
Dec 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11888
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨