Fix incorrectly wrapped arrow functions with return types #10940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+184
to
+186
| if (willBreak(returnTypeDoc)) { | ||
| throw new ArgExpansionBailout(); | ||
| } |
There was a problem hiding this comment.
Can you add tests that matches this condition?
Comment on lines
+148
to
+150
| ( | ||
| thing: string | ||
| ): complex< |
There was a problem hiding this comment.
It may be a trivial matter, but this line breaks is expected?
There was a problem hiding this comment.
It's not, but it's a separate issue
sosukesuzuki
approved these changes
May 24, 2021
|
I still remembered how these things work after working on #10712. BTW, first I thought this is a regression in 2.3, but it turned out it's an old bug. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #10923
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨