Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle targetOnCompletion with multiple query parameters #3

Open
poshjosh opened this issue Apr 20, 2021 · 0 comments
Open

Handle targetOnCompletion with multiple query parameters #3

poshjosh opened this issue Apr 20, 2021 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@poshjosh
Copy link
Owner

Forms use the targetOnCompletion field to specify where the form should return to on completion.

When the field has multiple query parameters e.g

/api/v1/webform/create/address/?parentfid=form178f09d8694&targetOnCompletion=/webform/create/delivery-details?order.id=1&fid=form178f09d8694

then it is not handled properly by

FormParamsUtil.java#L29

The above method extracts the fid=form178f09d8694as part of the Form's properties where as it is a part oftargetOnCompletion=/webform/create/delivery-details?order.id=1&fid=form178f09d8694`
and should not be part of the Form's properties. It is targetOnCompletion that is a form property.

We need to properly handle a targetOnCompletion comprising of multiple query parameters.

@poshjosh poshjosh added bug Something isn't working enhancement New feature or request labels Apr 20, 2021
@poshjosh poshjosh self-assigned this Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant