There's already a workflow for this - docs-rust.yml. But it only builds for the polars package. We could do all the docs checks there?

There's already a workflow for this - docs-rust.yml

Doesn't that one build and publishes the docs?

This one tests them and fails CI if they fail. The release today failed building docs.

Doesn't that one build and publishes the docs?

It's a combination. The workflow builds the docs and fails if they cannot be built. Then if it's on the main branch, it publishes the result.

I guess we should add the full make doctest command there, instead of just the polars package.

The point is, it should not fail on main, but on the PR. If a PR introduces a failing doctest, it should not be merged.

The docstest on main, doesn't have to run. At that point, we should be certain the docs are correct and just publish them.

The point is, it should not fail on main, but on the PR.

That's what it does. Just change this:

To:

      - name: Build Rust documentation
        env:
          RUSTDOCFLAGS: --cfg docsrs -D warnings
        working-directory: polars
        run: make doctest

Ok, will do!

You'll probably have to fix a few warnings though - mostly links that need to be proper hyperlinks, and a few feature gates. I was just looking at that locally 😄