Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rust): Fix all clippy warnings in the test suite #9839

Merged
merged 8 commits into from
Jul 12, 2023
Merged

chore(rust): Fix all clippy warnings in the test suite #9839

merged 8 commits into from
Jul 12, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jul 12, 2023 •
edited
Loading

...and check for warnings in the CI by running clippy with --all-targets.

@github-actions github-actions bot added chore Maintenance work that does not impact the user rust Related to Rust Polars labels Jul 12, 2023
@stinodego stinodego changed the title chore(rust): Fix a bunch of clippy warnings in the test suite chore(rust): Fix all clippy warnings in the test suite Jul 12, 2023
@stinodego stinodego marked this pull request as ready for review July 12, 2023 16:46
@stinodego stinodego marked this pull request as draft July 12, 2023 16:46
@stinodego stinodego marked this pull request as ready for review July 12, 2023 17:09
@ritchie46
Copy link
Member

Great stuff!

@ritchie46 ritchie46 merged commit 18aae76 into main Jul 12, 2023
@ritchie46 ritchie46 deleted the fix-rust-tests branch July 12, 2023 17:24
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@stinodego @c-peters
chore(rust): Fix all clippy warnings in the test suite (pola-rs#9839)
716f8ef
@stinodego stinodego added the internal An internal refactor or improvement label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees
No one assigned
Labels
chore Maintenance work that does not impact the user internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stinodego @ritchie46