Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rust): unswap from_tz and to_tz in replace_timezone #9768

Merged
merged 1 commit into from
Jul 9, 2023
Merged

chore(rust): unswap from_tz and to_tz in replace_timezone #9768

merged 1 commit into from
Jul 9, 2023

Conversation

MarcoGorelli
Copy link
Collaborator

I find the way it's currently written is quite confusing, as from_tz and to_tz are swapped

@github-actions github-actions bot added chore Maintenance work that does not impact the user rust Related to Rust Polars labels Jul 7, 2023
@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 7, 2023 15:50
stinodego
stinodego approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good catch!

@MarcoGorelli MarcoGorelli merged commit 5ceee5b into pola-rs:main Jul 9, 2023
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@MarcoGorelli @c-peters
chore(rust): unswap from_tz and to_tz in replace_timezone (pola-rs#9768)
c203edc
@stinodego stinodego added the internal An internal refactor or improvement label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
chore Maintenance work that does not impact the user internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGorelli @stinodego