Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust, python): change sampling ratio for groupby strategy #8223

Merged
merged 2 commits into from
Apr 14, 2023
Merged

refactor(rust, python): change sampling ratio for groupby strategy #8223

merged 2 commits into from
Apr 14, 2023

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Apr 14, 2023 •
edited
Loading

Sample by sqrt(N) as this samples more data on smaller sets and saturates better on larger datasets.

@github-actions github-actions bot added python Related to Python Polars refactor Code improvements that do not change functionality rust Related to Rust Polars labels Apr 14, 2023
@ritchie46 ritchie46 merged commit ddadac8 into main Apr 14, 2023
@ritchie46 ritchie46 deleted the sampling branch April 14, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
python Related to Python Polars refactor Code improvements that do not change functionality rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ritchie46