Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust): use SchemaRef in CSV modules #7250

Merged
merged 3 commits into from
Mar 2, 2023
Merged

refactor(rust): use SchemaRef in CSV modules #7250

merged 3 commits into from
Mar 2, 2023

Conversation

mslapek
Copy link
Contributor

@mslapek mslapek commented Feb 28, 2023

Replaces various Schema references with SchemaRef in CSV modules.
Added StringColumns as a bonus to reduce unsafe Rust.

This makes API more consistent, because SchemaRef is already used in the public polars API.

This PR removes 3 unsafes. ✨

@github-actions github-actions bot added refactor Code improvements that do not change functionality rust Related to Rust Polars labels Feb 28, 2023
@ritchie46
Copy link
Member

Initially we only accepted a schema reference so that you don't have to own the schema. But I agree that it is a bit of niche use case, so let's go forward with this.

@ritchie46 ritchie46 merged commit 48c90ad into pola-rs:master Mar 2, 2023
@mslapek
Copy link
Contributor Author

mslapek commented Mar 3, 2023

@ritchie46 Thanks for the review! 🎱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Code improvements that do not change functionality rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mslapek @ritchie46