Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add MarkDown linter support via dprint. #5576

Merged
merged 1 commit into from
Nov 22, 2022
Merged

chore: Add MarkDown linter support via dprint. #5576

merged 1 commit into from
Nov 22, 2022

Conversation

ghuls
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the chore Maintenance work that does not impact the user label Nov 21, 2022
stinodego
stinodego approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Makes dprint more useful.

Copy link
Collaborator Author

Theoretically it can also run rustfmt, but not sure if we should add it here too or not.

The top level Makefile to run the formatter on all files would be useful again to have them formatted locally.
#5563

@ritchie46 ritchie46 merged commit 4e35d9c into pola-rs:master Nov 22, 2022
@ritchie46
Copy link
Member

This yaml seems to be invalid. Every CI run this fails.

@stinodego
Copy link
Member

stinodego commented Nov 22, 2022 •
edited
Loading

Ah yeah, the **md and **toml should be on separate lines. File should start like this:

on:
  pull_request:
    paths:
      - '**.md'
      - '**.toml'
      - '.github/workflows/lint-global.yaml'

@stinodego stinodego mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

Assignees
No one assigned
Labels
chore Maintenance work that does not impact the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ritchie46 @stinodego