Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(python): Build wheels for ARM Windows in Python release workflow #20247

Merged
merged 2 commits into from
Dec 12, 2024
Merged

build(python): Build wheels for ARM Windows in Python release workflow #20247

merged 2 commits into from
Dec 12, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Dec 10, 2024 •
edited
Loading

This involves a manual step to downloads build tools and setup a rust environment on ARM Windows. Our existing x86 Windows runner apparently has this done automatically but I'm not sure how, as I couldn't find any explicit steps in the workflow file to do this.

Successful workflow run can be seen here - https://github.com/pola-rs/polars/actions/runs/12272593897/job/34241658384

@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars labels Dec 10, 2024
@nameexhaustion nameexhaustion force-pushed the build-python-windows-arm64 branch from 33c9012 to 07e0dc5 Compare December 10, 2024 13:03
@nameexhaustion nameexhaustion force-pushed the build-python-windows-arm64 branch from 63ada9d to 692480b Compare December 11, 2024 10:44
@nameexhaustion nameexhaustion changed the title build(python): Build python windows arm64 build(python): Build wheels for ARM Windows in Python release workflow Dec 11, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review December 11, 2024 10:52
@nameexhaustion nameexhaustion marked this pull request as draft December 12, 2024 05:22
@nameexhaustion nameexhaustion marked this pull request as ready for review December 12, 2024 05:51
@ritchie46
Copy link
Member

Haha.. All that powershell. 🙈

@ritchie46 ritchie46 merged commit 0869598 into main Dec 12, 2024
1 of 24 checks passed
@ritchie46 ritchie46 deleted the build-python-windows-arm64 branch December 12, 2024 10:14
@c-peters c-peters added the accepted Ready for implementation label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees

@nameexhaustion nameexhaustion

Labels
accepted Ready for implementation build Changes that affect the build system or external dependencies python Related to Python Polars
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nameexhaustion @ritchie46 @c-peters