Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move all describe, describe_tree and dot-viz code to IR instead of DslPlan #16237

Merged
merged 11 commits into from
May 15, 2024
Merged

refactor: move all describe, describe_tree and dot-viz code to IR instead of DslPlan #16237

merged 11 commits into from
May 15, 2024

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@coastalwhite coastalwhite changed the title Move all describe, describe_tree and dot-viz code to IR instead of DslPlan refactor: move all describe, describe_tree and dot-viz code to IR instead of DslPlan May 15, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels May 15, 2024
@codecov Codecov
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 37.32057% with 393 lines in your changes are missing coverage. Please review.

Project coverage is 80.85%. Comparing base (a34ca2c) to head (ca70478).

Files Patch % Lines
...es/polars-plan/src/logical_plan/alp/tree_format.rs 3.98% 193 Missing ⚠️
crates/polars-plan/src/logical_plan/alp/dot.rs 53.03% 116 Missing ⚠️
crates/polars-plan/src/logical_plan/alp/mod.rs 57.77% 19 Missing ⚠️
crates/polars-plan/src/logical_plan/mod.rs 18.75% 13 Missing ⚠️
...es/polars-lazy/src/physical_plan/streaming/tree.rs 0.00% 9 Missing ⚠️
crates/polars-plan/src/logical_plan/alp/format.rs 85.18% 8 Missing ⚠️
py-polars/src/lazyframe/mod.rs 50.00% 8 Missing ⚠️
crates/polars-plan/src/logical_plan/expr_ir.rs 0.00% 7 Missing ⚠️
...ates/polars-plan/src/logical_plan/functions/mod.rs 16.66% 5 Missing ⚠️
crates/polars-lazy/src/frame/mod.rs 60.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16237      +/-   ##
==========================================
+ Coverage   80.83%   80.85%   +0.02%     
==========================================
  Files        1394     1394              
  Lines      180095   179488     -607     
  Branches     2913     2913              
==========================================
- Hits       145577   145128     -449     
+ Misses      34015    33857     -158     
  Partials      503      503

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ritchie46
ritchie46 approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! @coastalwhite

@ritchie46 ritchie46 merged commit d7d720a into pola-rs:main May 15, 2024
27 checks passed
@coastalwhite coastalwhite deleted the ir-tree-format branch May 15, 2024 15:16
@cmdlineluser cmdlineluser mentioned this pull request May 15, 2024
Closed
2 tasks
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees

@coastalwhite coastalwhite

Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coastalwhite @ritchie46 @c-peters