feat(python): Enable Null datatype and null values by default in parametric testing #16192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16192 +/- ##
==========================================
- Coverage 81.00% 80.99% -0.01%
==========================================
Files 1392 1392
Lines 178943 178930 -13
Branches 2901 2904 +3
==========================================
- Hits 144947 144924 -23
- Misses 33491 33503 +12
+ Partials 505 503 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null values are a frequent source of bugs, so we should really be testing for them.
Changes
Nulldata type by default. Dataframes/Series generated by our strategies may contain aNullcolumn.allow_nulltoTrueby default. This may hit some users, but we should really make the change now while people are updating their parametric tests anyway.allow_null=Falsewill exlude theNulldata type from the pool.This helped me find a bug, will investigate later:
#16190