Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Don't rechunk by default in concat #16128

Merged
merged 4 commits into from
May 9, 2024
Merged

perf: Don't rechunk by default in concat #16128

merged 4 commits into from
May 9, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels May 9, 2024
@codecov Codecov
Copy link

codecov bot commented May 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (f18c306) to head (72bec1e).
Report is 2 commits behind head on main.

❗ Current head 72bec1e differs from pull request most recent head 8e90612. Consider uploading reports for the commit 8e90612 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #16128   +/-   ##
=======================================
  Coverage   80.95%   80.96%           
=======================================
  Files        1386     1386           
  Lines      178441   178440    -1     
  Branches     2883     2883           
=======================================
+ Hits       144452   144467   +15     
+ Misses      33494    33480   -14     
+ Partials      495      493    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #16128 will not alter performance

Comparing concat (8e90612) with main (16245cd)

Summary

✅ 35 untouched benchmarks

@ritchie46 ritchie46 merged commit 475bac5 into main May 9, 2024
27 checks passed
@ritchie46 ritchie46 deleted the concat branch May 9, 2024 12:56
@eitsupi eitsupi mentioned this pull request May 9, 2024
Closed
@Elvynzs Elvynzs mentioned this pull request May 27, 2024
Closed
2 tasks
@mcrumiller mcrumiller mentioned this pull request Aug 6, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ritchie46