Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Add docstring examples for datetimes (#13161) #15804

Merged
merged 5 commits into from
Apr 20, 2024

Conversation

NedJWestern
Copy link
Contributor

See #13161

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Apr 20, 2024
@MarcoGorelli
Copy link
Collaborator

nice, good to have these - looks like there's a doctest failure, can you run make doctest please?

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.39%. Comparing base (0c37ead) to head (102c5d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15804      +/-   ##
==========================================
- Coverage   80.39%   80.39%   -0.01%     
==========================================
  Files        1264     1264              
  Lines      165421   165423       +2     
==========================================
- Hits       132994   132993       -1     
- Misses      32427    32430       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NedJWestern NedJWestern marked this pull request as draft April 20, 2024 11:24
@NedJWestern
Copy link
Contributor Author

Oops... should be fixed now.

@NedJWestern NedJWestern marked this pull request as ready for review April 20, 2024 12:26
@alexander-beedie
Copy link
Collaborator

Good stuff - very helpful! ✌️

@alexander-beedie alexander-beedie merged commit 56dda21 into pola-rs:main Apr 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants