Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Fix NaN ordering to make NaNs compare greater than any other float, and equal to themselves #12721

Merged
merged 35 commits into from
Nov 30, 2023
Merged

fix!: Fix NaN ordering to make NaNs compare greater than any other float, and equal to themselves #12721

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
434a7d7
move TotalOrd to polars-utils
orlp Oct 16, 2023
a309b3b
add polars-compute
orlp Oct 16, 2023
eaed1e7
wip
orlp Oct 17, 2023
c1912d6
remove nans_compare_equal
orlp Nov 23, 2023
913a4f1
remove float comparison exceptions
orlp Nov 23, 2023
d37d9c0
mostly fix broadcasting comparisons
orlp Nov 24, 2023
01fb1bb
remove inconsistent null equality optimization
orlp Nov 27, 2023
33f09b9
add warning to always-null comparisons
orlp Nov 27, 2023
3c5e101
fmt
orlp Nov 27, 2023
14e43eb
fix warnings in tests
orlp Nov 27, 2023
5c4a943
fix _missing comparison ops
orlp Nov 27, 2023
467b7fc
clippy
orlp Nov 27, 2023
d7fb115
remove not_equal_and_validity
orlp Nov 28, 2023
5354923
add new string comparison kernels
orlp Nov 28, 2023
da58d14
define gt/ge in terms of lt/le
orlp Nov 28, 2023
74f4e3f
add _missing kernels
orlp Nov 28, 2023
b6359c4
add array support to comparison kernels
orlp Nov 28, 2023
a50997d
fmt/clippy
orlp Nov 28, 2023
5a2c321
add boolean comparison kernels
orlp Nov 29, 2023
06b9426
expand comparison tests
orlp Nov 29, 2023
80a12d9
fix test
orlp Nov 29, 2023
0b93380
user new string broadcast comparison kernels
orlp Nov 29, 2023
ed030c3
remove old comparison kernels
orlp Nov 29, 2023
ba409a4
clippy
orlp Nov 29, 2023
ea99583
fix bad/outdated tests
orlp Nov 29, 2023
9013166
fix trait bounds
orlp Nov 29, 2023
3c63fec
fix conditional import
orlp Nov 29, 2023
cb4da95
fix another bad test
orlp Nov 29, 2023
1bd4957
fix failing doctest
orlp Nov 29, 2023
ba8c5e2
address review comments
orlp Nov 30, 2023
d58dc7c
fix mypy
orlp Nov 30, 2023
e2e8b85
fix incorrect bitcount
orlp Nov 30, 2023
3b00eb1
add missing inline
orlp Nov 30, 2023
733c634
add missing comment
orlp Nov 30, 2023
7a340e4
fmt
orlp Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix failing doctest
  • Loading branch information
@orlp
orlp committed Nov 29, 2023
commit 1bd4957ee94394fde7ad80e3ad2de0aacc69876d
12 changes: 6 additions & 6 deletions py-polars/polars/expr/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4593,7 +4593,7 @@ def eq(self, other: Any) -> Self:
╞═════╪═════╪════════╡
│ 1.0 ┆ 2.0 ┆ false │
│ 2.0 ┆ 2.0 ┆ true │
│ NaN ┆ NaN ┆ false │
│ NaN ┆ NaN ┆ true │
│ 4.0 ┆ 4.0 ┆ true │
└─────┴─────┴────────┘

Expand Down Expand Up @@ -4631,7 +4631,7 @@ def eq_missing(self, other: Any) -> Self:
╞══════╪══════╪════════╪════════════════╡
│ 1.0 ┆ 2.0 ┆ false ┆ false │
│ 2.0 ┆ 2.0 ┆ true ┆ true │
│ NaN ┆ NaN ┆ false ┆ false │
│ NaN ┆ NaN ┆ true ┆ true │
│ 4.0 ┆ 4.0 ┆ true ┆ true │
│ null ┆ 5.0 ┆ null ┆ false │
│ null ┆ null ┆ null ┆ true │
Expand Down Expand Up @@ -4668,7 +4668,7 @@ def ge(self, other: Any) -> Self:
╞═════╪═════╪════════╡
│ 5.0 ┆ 5.0 ┆ true │
│ 4.0 ┆ 3.0 ┆ true │
│ NaN ┆ NaN ┆ false │
│ NaN ┆ NaN ┆ true │
│ 2.0 ┆ 1.0 ┆ true │
└─────┴─────┴────────┘

Expand Down Expand Up @@ -4738,7 +4738,7 @@ def le(self, other: Any) -> Self:
╞═════╪═════╪════════╡
│ 5.0 ┆ 5.0 ┆ true │
│ 4.0 ┆ 3.5 ┆ false │
│ NaN ┆ NaN ┆ false │
│ NaN ┆ NaN ┆ true │
│ 0.5 ┆ 2.0 ┆ true │
└─────┴─────┴────────┘

Expand Down Expand Up @@ -4808,7 +4808,7 @@ def ne(self, other: Any) -> Self:
╞═════╪═════╪════════╡
│ 1.0 ┆ 2.0 ┆ true │
│ 2.0 ┆ 2.0 ┆ false │
│ NaN ┆ NaN ┆ true │
│ NaN ┆ NaN ┆ false │
│ 4.0 ┆ 4.0 ┆ false │
└─────┴─────┴────────┘

Expand Down Expand Up @@ -4846,7 +4846,7 @@ def ne_missing(self, other: Any) -> Self:
╞══════╪══════╪════════╪════════════════╡
│ 1.0 ┆ 2.0 ┆ true ┆ true │
│ 2.0 ┆ 2.0 ┆ false ┆ false │
│ NaN ┆ NaN ┆ true ┆ true │
│ NaN ┆ NaN ┆ false ┆ false │
│ 4.0 ┆ 4.0 ┆ false ┆ false │
│ null ┆ 5.0 ┆ null ┆ true │
│ null ┆ null ┆ null ┆ false │
Expand Down