Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @lukaszstolarczuk)

doc/groups_definitions.dox, line 166 at r1 (raw file):

in this group provide

Classes which provide....

Using "group" word may cause confusion, as it's in "features", and we do not define what is "group" anywhare.

Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @lukaszstolarczuk)

include/libpmemobj++/slice.hpp, line 51 at r1 (raw file):

 * access to that sequence, with the help of iterators. It's used e.g. in
 * several data structures to deliver `range` methods. As an example please see:
 * pmem::obj::vector::range() .

It might be worth mentioning that slice can be used with any Iterator type which ... fulfills the static_assert in the constructor (you can just copy the condition here or write it in English). ?

Reviewable status: 5 of 8 files reviewed, 2 unresolved discussions (waiting on @igchor and @karczex)

doc/groups_definitions.dox, line 166 at r1 (raw file):

Done.

include/libpmemobj++/slice.hpp, line 51 at r1 (raw file):

Done.

Reviewable status: 5 of 8 files reviewed, 2 unresolved discussions (waiting on @igchor and @karczex)

Reviewed 1 of 3 files at r2.
Reviewable status: 6 of 8 files reviewed, 4 unresolved discussions (waiting on @igchor, @karczex, and @lukaszstolarczuk)

include/libpmemobj++/slice.hpp, line 118 at r3 (raw file):

	/**
	 * @return reverse_iterator to the end of the slice's range.

Isn't is reverse iterator to the beginning of the slice range?

In cppreference they are calling it "reverse-beginning". I'm not sure it it's best name :)

Maybe add some ascii-art similar to picture on https://en.cppreference.com/w/cpp/iterator/rbegin
https://asciiflow.com/#/ this diagram editor may be useful
...

include/libpmemobj++/slice.hpp, line 127 at r3 (raw file):

	/**
	 * @return reverse_iterator to the beginning of the slice's range.

... end?

include/libpmemobj++/slice.hpp, line 154 at r3 (raw file):

Access operator

Formally, the name is Subscript Operator
https://docs.microsoft.com/en-us/cpp/cpp/subscript-operator?view=msvc-160

Reviewed 1 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @lukaszstolarczuk)

include/libpmemobj++/slice.hpp, line 48 at r3 (raw file):

"view"

view in database and C++ terminology is a construct that points to memory or data and don't own data (just aggregates), so typing around "" forces reader to think that it's a metaphor, but it's not.

See: https://en.cppreference.com/w/cpp/ranges

include/libpmemobj++/slice.hpp, line 69 at r3 (raw file):

define

Constructor defines or define?

Reviewable status: 6 of 8 files reviewed, 5 unresolved discussions (waiting on @karczex and @KFilipek)

include/libpmemobj++/slice.hpp, line 48 at r3 (raw file):

Done.

include/libpmemobj++/slice.hpp, line 69 at r3 (raw file):

iterators define a range

"which" describing ctor will be placed like this:
ctor, which defines ..., takes ...

include/libpmemobj++/slice.hpp, line 118 at r3 (raw file):

Actually, I like the "reverse beginning". I'll merge this naming with the extended description (based on pmem::obj::string_view descriptions)

include/libpmemobj++/slice.hpp, line 127 at r3 (raw file):

Done.

include/libpmemobj++/slice.hpp, line 154 at r3 (raw file):

och, nice. Done.

Reviewable status: 6 of 8 files reviewed, 2 unresolved discussions (waiting on @KFilipek)

Reviewed 1 of 2 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)