Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes type declarations to allow for no options, closes #326 #327

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Fixes type declarations to allow for no options, closes #326 #327

merged 1 commit into from
Apr 7, 2022

Conversation

daniel-j-h
Copy link
Contributor

For #326. cc @mcollina

mcollina
mcollina approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2107514801

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 2088835673: 0.0%
Covered Lines: 380
Relevant Lines: 380
💛 - Coveralls

@mcollina mcollina merged commit 85d47c9 into pinojs:master Apr 7, 2022
@daniel-j-h daniel-j-h deleted the issues/326 branch April 7, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-j-h @coveralls @mcollina