native only evals at end of render #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Co-authored-by: Martin Krizek <[email protected]>
4 tasks
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Apr 14, 2020
With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned.
mkrizek
added a commit
to ansible/ansible
that referenced
this pull request
Apr 17, 2020
With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned.
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Apr 20, 2020
With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned. (cherry picked from commit acdc9eb)
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Apr 20, 2020
With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned. (cherry picked from commit acdc9eb)
With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned.
With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned.
mattclay
pushed a commit
to ansible/ansible
that referenced
this pull request
May 6, 2020
* native types: literal_eval all the things (#68938) With pallets/jinja#1190 merged our short-circuit is no longer valid (has it ever been?) as now data like ' True ' may go through our ansible_native_concat function as opposed to going through intermediate call to Jinja2's native_concat before. Now we need to always send data through literal_eval to ensure native types are returned. (cherry picked from commit acdc9eb) * Fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If each intermediate group was converted, it could change the final value. The example given in the test is that the string
0.000evaluates to a float, then renders as0.0when combined later, so0.000{{ 7 }}would result in0.07. Instead, intermediate groups are joined as strings, and only the final result is passed tonative_concat. This also removes the need forpreserve_quotesfrom #1086.submitted by @mkrizek, closes #1186