fix: CRD WebhookConversion respect WEBHOOK_HOST env #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fungaren <[email protected]>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2217 +/- ##
===========================================
- Coverage 58.93% 45.23% -13.71%
===========================================
Files 210 404 +194
Lines 18968 27820 +8852
===========================================
+ Hits 11179 12583 +1404
- Misses 6707 14006 +7299
- Partials 1082 1231 +149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
YurtManager watches ValidatingWebhookConfiguration and MutatingWebhookConfiguration and update its
clientConfigaccording to theWEBHOOK_HOSTenvironment variable.However, some CRDs (eg.
NodePool) also include theclientConfigfield inspec.conversion.webhook, and the Helm chart already set it. It seems the YurtManager forgot to update it while updatingcrd.Spec.Conversion.Webhook.ClientConfig.CABundle.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note