Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wikipedia link with question mark #10065

Closed
alnzrv opened this issue Jan 12, 2024 · 1 comment · Fixed by #10165
Closed

Wikipedia link with question mark #10065

alnzrv opened this issue Jan 12, 2024 · 1 comment · Fixed by #10165

Comments

@alnzrv
Copy link

alnzrv commented Jan 12, 2024 •
edited
Loading

URL

https://www.openstreetmap.org/edit?way=394705975#map=19/44.81767/20.45303

How to reproduce the issue?

  1. Clear the wikipedia tag.
  2. Select language "српски / srpski".
  3. Start typing "Кафана „?”". Select such value from the drop-down.
  4. Click on the button "view on wikipedia.org".
  5. You will get the error page in the browser.

Screenshot(s) or anything else?

Tag "wikipedia=sr:Кафана_„%3F”" works, tag "wikipedia=sr:Кафана „?”" doesn't.
If you save tag "wikipedia=sr:Кафана „?”" problem will stay in the view (not the edit) mode too.

1
2
image

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.27.3

Which browsers are you seeing this problem on?

Chrome
@Asif-Sheriff
Copy link
Contributor

In URL encoding, "?" is represented as "%3F"
That is why Кафана_„%3F” works while the former doesn't.

@hirako2000 hirako2000 mentioned this issue Mar 17, 2024
Merged
bhousel added a commit to facebook/Rapid that referenced this issue Apr 29, 2024
@bhousel
Improved handling of wikipedia url encoding
52ac671 
re: #1389
re: openstreetmap/iD#10065
re: openstreetmap/iD#10165
@bhousel bhousel mentioned this issue Apr 29, 2024
Closed
12 tasks
@alnzrv alnzrv mentioned this issue May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Field: fix wikiURL by URL encoding it - and slight refactors hirako2000/iD
2 participants
@alnzrv @Asif-Sheriff